Fix minor issues in the transfer server.

project-chip · Aug 22, 2024 · 3680655 · 3680655
1 parent af4bd78
commit 3680655
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 9 deletions.
diff --git a/src/controller/python/chip/bdx/bdx-transfer-server.cpp b/src/controller/python/chip/bdx/bdx-transfer-server.cpp
@@ -40,16 +40,11 @@ void BdxTransferServer::Shutdown()
     mExchangeManager = nullptr;
 }
 
-CHIP_ERROR BdxTransferServer::OnUnsolicitedMessageReceived(const PayloadHeader& payloadHeader,
+CHIP_ERROR BdxTransferServer::OnUnsolicitedMessageReceived(const PayloadHeader & payloadHeader,
                                                            Messaging::ExchangeDelegate *& delegate)
 {
-    // TODO: Verify details from the payload header.
     BdxTransfer * transfer = mBdxTransferPool->Allocate();
-    if (!transfer)
-    {
-        return CHIP_ERROR_NO_MEMORY;
-    }
-
+    VerifyOrReturnError(transfer != nullptr, CHIP_ERROR_NO_MEMORY);
     delegate = transfer;
     return CHIP_NO_ERROR;
 }

diff --git a/src/controller/python/chip/bdx/bdx-transfer-server.h b/src/controller/python/chip/bdx/bdx-transfer-server.h
@@ -26,7 +26,8 @@
 namespace chip {
 namespace bdx {
 
-// This class handles incoming BDX init messages to start BDX transfers. It allocates BdxTransfer objects from a pool.
+// This class handles incoming BDX init messages to start BDX transfers. It requests the BdxTransfer objects from a pool
+// and uses them as exchange delegates.
 class BdxTransferServer : public Messaging::UnsolicitedMessageHandler
 {
 public:
@@ -35,7 +36,7 @@ class BdxTransferServer : public Messaging::UnsolicitedMessageHandler
     CHIP_ERROR Init(Messaging::ExchangeManager * exchangeManager);
     void Shutdown();
 
-    CHIP_ERROR OnUnsolicitedMessageReceived(const PayloadHeader& payloadHeader, Messaging::ExchangeDelegate *& delegate) override;
+    CHIP_ERROR OnUnsolicitedMessageReceived(const PayloadHeader & payloadHeader, Messaging::ExchangeDelegate *& delegate) override;
     void OnExchangeCreationFailed(Messaging::ExchangeDelegate * delegate) override;
 
 private: