Skip to content

Commit

Permalink
fix tv ( only supports ethernet commission ) always DeleteAllFabrics (#…
Browse files Browse the repository at this point in the history
…13181)

* fix tv ( only supports ethernet commission ) always DeleteAllFabrics every start issue

* fix Linux test failed: remove all Fabrics before next testcase
  • Loading branch information
xylophone21 authored Jan 4, 2022
1 parent 88572ac commit 360252c
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 2 deletions.
4 changes: 4 additions & 0 deletions scripts/tests/chiptest/test_definition.py
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ def Run(self, runner, paths: ApplicationPaths):
if os.path.exists('/tmp/chip_tool_config.ini'):
os.unlink('/tmp/chip_tool_config.ini')

# Remove server all_clusters_app or tv_app storage, so it will be commissionable again
if os.path.exists('/tmp/chip_kvs'):
os.unlink('/tmp/chip_kvs')

discriminator = str(randrange(1, 4096))
logging.debug(
'Executing application under test with discriminator %s.' % discriminator)
Expand Down
5 changes: 3 additions & 2 deletions src/app/server/Server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -194,12 +194,13 @@ CHIP_ERROR Server::Init(AppDelegate * delegate, uint16_t secureServicePort, uint
ChipLogProgress(AppServer, "Rendezvous and secure pairing skipped");
SuccessOrExit(err = AddTestCommissioning());
}
else if ((DeviceLayer::ConnectivityMgr().IsWiFiStationProvisioned() || DeviceLayer::ConnectivityMgr().IsThreadProvisioned()) &&
(GetFabricTable().FabricCount() != 0))
else if (GetFabricTable().FabricCount() != 0)
{
// The device is already commissioned, proactively disable BLE advertisement.
ChipLogProgress(AppServer, "Fabric already commissioned. Disabling BLE advertisement");
#if CONFIG_NETWORK_LAYER_BLE
chip::DeviceLayer::ConnectivityMgr().SetBLEAdvertisingEnabled(false);
#endif
}
else
{
Expand Down

0 comments on commit 360252c

Please sign in to comment.