The ExchangeContext is not closed once a message has been dispatched …

…via CHIPDeviceController to a CHIPDevice (#6045)
project-chip · Apr 15, 2021 · 3120ae8 · 3120ae8
1 parent 467dd44
commit 3120ae8
Showing 1 changed file with 10 additions and 6 deletions.
diff --git a/src/controller/CHIPDeviceController.cpp b/src/controller/CHIPDeviceController.cpp
@@ -391,16 +391,20 @@ CHIP_ERROR DeviceController::ServiceEventSignal()
 void DeviceController::OnMessageReceived(Messaging::ExchangeContext * ec, const PacketHeader & packetHeader,
                                          const PayloadHeader & payloadHeader, System::PacketBufferHandle msgBuf)
 {
-    VerifyOrReturn(mState == State::Initialized, ChipLogError(Controller, "OnMessageReceived was called in incorrect state"));
+    uint16_t index;
 
-    VerifyOrReturn(packetHeader.GetSourceNodeId().HasValue(),
-                   ChipLogError(Controller, "OnMessageReceived was called for unknown source node"));
+    VerifyOrExit(mState == State::Initialized, ChipLogError(Controller, "OnMessageReceived was called in incorrect state"));
 
-    uint16_t index = FindDeviceIndex(packetHeader.GetSourceNodeId().Value());
-    VerifyOrReturn(index < kNumMaxActiveDevices,
-                   ChipLogError(Controller, "OnMessageReceived was called for unknown device object"));
+    VerifyOrExit(packetHeader.GetSourceNodeId().HasValue(),
+                 ChipLogError(Controller, "OnMessageReceived was called for unknown source node"));
+
+    index = FindDeviceIndex(packetHeader.GetSourceNodeId().Value());
+    VerifyOrExit(index < kNumMaxActiveDevices, ChipLogError(Controller, "OnMessageReceived was called for unknown device object"));
 
     mActiveDevices[index].OnMessageReceived(packetHeader, payloadHeader, std::move(msgBuf));
+
+exit:
+    ec->Close();
 }
 
 void DeviceController::OnResponseTimeout(Messaging::ExchangeContext * ec)