Sync error code returning by SetTemperature command with spec (#28910)

project-chip · Apr 26, 2024 · 2764049 · 2764049
1 parent 9e3b2cf
commit 2764049
Showing 1 changed file with 14 additions and 2 deletions.
diff --git a/src/app/clusters/temperature-control-server/temperature-control-server.cpp b/src/app/clusters/temperature-control-server/temperature-control-server.cpp
@@ -172,7 +172,13 @@ bool emberAfTemperatureControlClusterSetTemperatureCallback(app::CommandHandler
             emberAfStatus = TemperatureSetpoint::Set(endpoint, targetTemperature.Value());
             if (emberAfStatus != EMBER_ZCL_STATUS_SUCCESS)
             {
-                status = app::ToInteractionModelStatus(emberAfStatus);
+                /**
+                 * If the server is unable to execute the command at the time the command is received
+                 * by the server (e.g. due to the design of a device it cannot accept a change in its
+                 * temperature setting after it has begun operation), then the server SHALL respond
+                 * with a status code of INVALID_IN_STATE, and discard the command.
+                 **/
+                status = Status::InvalidInState;
             }
         }
         else
@@ -200,7 +206,13 @@ bool emberAfTemperatureControlClusterSetTemperatureCallback(app::CommandHandler
                 emberAfStatus = SelectedTemperatureLevel::Set(endpoint, targetTemperatureLevel.Value());
                 if (emberAfStatus != EMBER_ZCL_STATUS_SUCCESS)
                 {
-                    status = app::ToInteractionModelStatus(emberAfStatus);
+                    /**
+                     * If the server is unable to execute the command at the time the command is received
+                     * by the server (e.g. due to the design of a device it cannot accept a change in its
+                     * temperature setting after it has begun operation), then the server SHALL respond
+                     * with a status code of INVALID_IN_STATE, and discard the command.
+                     **/
+                    status = Status::InvalidInState;
                 }
             }
             else