Incorrect handling of operational errors (#28942)

* Made the InEqual method const to enusre that the values are not modified. * Fixed the error checking in the OnOperationalErrorDetected method.
project-chip · Nov 3, 2023 · 2451672 · 2451672
1 parent 5920ea6
commit 2451672
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/app/clusters/operational-state-server/operational-state-cluster-objects.h b/src/app/clusters/operational-state-server/operational-state-cluster-objects.h
@@ -138,7 +138,7 @@ struct GenericOperationalError : public app::Clusters::detail::Structs::ErrorSta
         }
     }
 
-    bool IsEqual(const Structs::ErrorStateStruct::Type & rhs)
+    bool IsEqual(const Structs::ErrorStateStruct::Type & rhs) const
     {
         if (errorStateID != rhs.errorStateID)
         {

diff --git a/src/app/clusters/operational-state-server/operational-state-server.cpp b/src/app/clusters/operational-state-server/operational-state-server.cpp
@@ -136,7 +136,7 @@ void Instance::OnOperationalErrorDetected(const Structs::ErrorStateStruct::Type
     }
 
     // Set the OperationalError attribute
-    if (mOperationalError.IsEqual(aError))
+    if (!mOperationalError.IsEqual(aError))
     {
         mOperationalError.Set(aError.errorStateID, aError.errorStateLabel, aError.errorStateDetails);
         ConcreteAttributePath path = ConcreteAttributePath(mEndpointId, mClusterId, Attributes::OperationalError::Id);
-Original file line number
+Diff line change
@@ Expand Up @@
             }
         }
-        bool IsEqual(const Structs::ErrorStateStruct::Type & rhs)
+        bool IsEqual(const Structs::ErrorStateStruct::Type & rhs) const
         {
             if (errorStateID != rhs.errorStateID)
             {
@@ Expand Down @@