Skip to content

Commit

Permalink
Remove more warnings when building with Xcode - part 3 (#11837)
Browse files Browse the repository at this point in the history
* Remove more warnings when building with Xcode

* Update generated code
  • Loading branch information
vivien-apple authored and pull[bot] committed Jan 4, 2023
1 parent e6ae205 commit 2414816
Show file tree
Hide file tree
Showing 19 changed files with 12 additions and 4,377 deletions.
4 changes: 2 additions & 2 deletions src/app/ReadClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ class ReadClient : public Messaging::ExchangeDelegate
* The ReadClient object MUST continue to exist after this call is completed.
*
* @param[in] apReadClient The read client which initialized the read transaction.
* @param[in] apEventReportsReader TLV reader positioned at the list that contains the events. The
* @param[in] aEventReports TLV reader positioned at the list that contains the events. The
* implementation of EventStreamReceived is expected to call Next() on the reader to
* advance it to the first element of the list, then process the elements from beginning to
* the end. The callee is expected to consume all events.
Expand Down Expand Up @@ -215,7 +215,7 @@ class ReadClient : public Messaging::ExchangeDelegate
* - SubscribeResponseProcessed
*
* @param[in] apExchangeMgr A pointer to the ExchangeManager object.
* @param[in] apDelegate InteractionModelDelegate set by application.
* @param[in] apCallback InteractionModelDelegate set by application.
*
* @retval #CHIP_ERROR_INCORRECT_STATE incorrect state if it is already initialized
* @retval #CHIP_NO_ERROR On success.
Expand Down
8 changes: 0 additions & 8 deletions src/app/reporting/reporting.h
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,6 @@
* framework changes. The application should call this function when an
* externally-managed attribute changes. The application should use the change
* notification to inform its reporting decisions.
*
* @param endpoint
* @param clusterId
* @param attributeId
* @param mask
* @param manufacturerCode
* @param type
* @param data
*/
void MatterReportingAttributeChangeCallback(chip::EndpointId endpoint, chip::ClusterId clusterId, chip::AttributeId attributeId,
uint8_t mask, uint16_t manufacturerCode, EmberAfAttributeType type, uint8_t * data);
Expand Down
283 changes: 0 additions & 283 deletions src/app/zap-templates/templates/app/callback-stub-src.zapt

Large diffs are not rendered by default.

66 changes: 5 additions & 61 deletions src/app/zap-templates/templates/app/callback.zapt
Original file line number Diff line number Diff line change
Expand Up @@ -172,8 +172,6 @@ bool emberAf{{asUpperCamelCase parent.label}}Cluster{{asUpperCamelCase name}}Cal
* application behaves with regard to sleeping and polling. Until the
* outstanding task is completed, the device may poll more frequently and sleep
* less often.
*
* @param tasks Ver.: always
*/
void emberAfAddToCurrentAppTasksCallback(EmberAfApplicationTask tasks);

Expand All @@ -186,8 +184,6 @@ void emberAfAddToCurrentAppTasksCallback(EmberAfApplicationTask tasks);
* from the list of outstanding tasks may allow the device to sleep longer and
* poll less frequently. If there are other outstanding tasks the system may
* still have to stay away and poll more often.
*
* @param tasks Ver.: always
*/
void emberAfRemoveFromCurrentAppTasksCallback(EmberAfApplicationTask tasks);

Expand Down Expand Up @@ -215,14 +211,6 @@ void emberAfRemoveFromCurrentAppTasksCallback(EmberAfApplicationTask tasks);
* is unlikely to be a problem for writing read-only attributes, but it may be a
* problem for attributes that are writeable according to the specification but
* restricted by the application implementing this callback.
*
* @param endpoint Ver.: always
* @param clusterId Ver.: always
* @param attributeId Ver.: always
* @param mask Ver.: always
* @param manufacturerCode Ver.: always
* @param value Ver.: always
* @param type Ver.: always
*/
EmberAfAttributeWritePermission emberAfAllowNetworkWriteAttributeCallback(chip::EndpointId endpoint, chip::ClusterId clusterId,
chip::AttributeId attributeId, uint8_t mask,
Expand All @@ -232,11 +220,6 @@ EmberAfAttributeWritePermission emberAfAllowNetworkWriteAttributeCallback(chip::
*
* This function is called whenever the Application Framework needs to check
* access permission for an attribute read.
*
* @param endpoint Ver.: always
* @param clusterId Ver.: always
* @param manufacturerCode Ver.: always
* @param attributeId Ver.: always
*/
bool emberAfAttributeReadAccessCallback(chip::EndpointId endpoint, chip::ClusterId clusterId, uint16_t manufacturerCode,
chip::AttributeId attributeId);
Expand All @@ -245,11 +228,6 @@ bool emberAfAttributeReadAccessCallback(chip::EndpointId endpoint, chip::Cluster
*
* This function is called whenever the Application Framework needs to check
* access permission for an attribute write.
*
* @param endpoint Ver.: always
* @param clusterId Ver.: always
* @param manufacturerCode Ver.: always
* @param attributeId Ver.: always
*/
bool emberAfAttributeWriteAccessCallback(chip::EndpointId endpoint, chip::ClusterId clusterId, uint16_t manufacturerCode,
chip::AttributeId attributeId);
Expand All @@ -260,11 +238,10 @@ bool emberAfAttributeWriteAccessCallback(chip::EndpointId endpoint, chip::Cluste
* command is received from an external device. The application should return
* true if the message was processed or false if it was not.
*
* @param clusterId The cluster identifier of this response. Ver.: always
* @param commandId The command identifier to which this is a response. Ver.:
* always
* @param clusterId The cluster identifier of this response.
* @param commandId The command identifier to which this is a response.
* @param status Specifies either SUCCESS or the nature of the error that was
* detected in the received command. Ver.: always
* detected in the received command.
*/
bool emberAfDefaultResponseCallback(chip::ClusterId clusterId, chip::CommandId commandId, EmberAfStatus status);

Expand All @@ -283,9 +260,9 @@ bool emberAfDefaultResponseCallback(chip::ClusterId clusterId, chip::CommandId c
* the mesasge and the framework will continue to process accordingly.
*
* @param messageStruct The structure containing the parameters of the APS
* message to be sent. Ver.: always
* message to be sent.
* @param status A pointer to the status code value that will be returned to the
* caller. Ver.: always
* caller.
*/
bool emberAfPreMessageSendCallback(EmberAfMessageStruct * messageStruct, EmberStatus * status);

Expand All @@ -299,12 +276,6 @@ bool emberAfPreMessageSendCallback(EmberAfMessageStruct * messageStruct, EmberSt
* callback should return a bool value of true or false. A value of true
* indicates that the message sent notification has been handled and should not
* be handled by the application framework.
*
* @param destination Ver.: always
* @param apsFrame Ver.: always
* @param msgLen Ver.: always
* @param message Ver.: always
* @param status Ver.: always
*/
bool emberAfMessageSentCallback(const chip::MessageSendDestination & destination, EmberApsFrame * apsFrame,
uint16_t msgLen, uint8_t * message, EmberStatus status);
Expand Down Expand Up @@ -337,14 +308,6 @@ bool emberAfMessageSentCallback(const chip::MessageSendDestination & destination
* of a buffer overflow throw an appropriate error such as
* EMBER_ZCL_STATUS_INSUFFICIENT_SPACE. Any other return value indicates the
* application was not able to read the attribute.
*
* @param endpoint Ver.: always
* @param clusterId Ver.: always
* @param attributeMetadata Ver.: always
* @param manufacturerCode Ver.: always
* @param buffer Ver.: always
* @param maxReadLength Ver.: always
* @param index Ver.: always
*/
EmberAfStatus emberAfExternalAttributeReadCallback(chip::EndpointId endpoint, chip::ClusterId clusterId,
EmberAfAttributeMetadata * attributeMetadata, uint16_t manufacturerCode,
Expand Down Expand Up @@ -389,13 +352,6 @@ EmberAfStatus emberAfExternalAttributeReadCallback(chip::EndpointId endpoint, ch
* write the attribute, it returns a value of EMBER_ZCL_STATUS_SUCCESS. Any
* other return value indicates the application was not able to write the
* attribute.
*
* @param endpoint Ver.: always
* @param clusterId Ver.: always
* @param attributeMetadata Ver.: always
* @param manufacturerCode Ver.: always
* @param buffer Ver.: always
* @param index Ver.: always
*/
EmberAfStatus emberAfExternalAttributeWriteCallback(chip::EndpointId endpoint, chip::ClusterId clusterId,
EmberAfAttributeMetadata * attributeMetadata, uint16_t manufacturerCode,
Expand Down Expand Up @@ -466,12 +422,6 @@ bool emberAfStartMoveCallback();
* the attribute is to be set by the framework. The application should return
* chip::Protocols::InteractionModel::Status::Success to permit the change or
* any other code to reject it.
*
* @param attributePath
* @param mask
* @param type
* @param size
* @param value
*/
chip::Protocols::InteractionModel::Status MatterPreAttributeChangeCallback(const chip::app::ConcreteAttributePath & attributePath,
uint8_t mask, uint8_t type, uint16_t size, uint8_t * value);
Expand All @@ -481,12 +431,6 @@ chip::Protocols::InteractionModel::Status MatterPreAttributeChangeCallback(const
* This function is called by the application framework after it changes an
* attribute value. The value passed into this callback is the value to which
* the attribute was set by the framework.
*
* @param attributePath
* @param mask
* @param type
* @param size
* @param value
*/
void MatterPostAttributeChangeCallback(const chip::app::ConcreteAttributePath & attributePath,
uint8_t mask, uint8_t type, uint16_t size, uint8_t * value);
Loading

0 comments on commit 2414816

Please sign in to comment.