Fix formatting of unknown IDs in MTRClusterNames bits. (#35922)

IDs are unsigned; we should not be formatting them with %d, because for vendor-prefixed ones that might make them look negative.
project-chip · Oct 4, 2024 · 213bf23 · 213bf23
1 parent cc28e0a
commit 213bf23
Show file tree

Hide file tree

Showing 2 changed files with 492 additions and 492 deletions.
diff --git a/src/darwin/Framework/CHIP/templates/MTRClusterNames-src.zapt b/src/darwin/Framework/CHIP/templates/MTRClusterNames-src.zapt
@@ -23,7 +23,7 @@ NSString * MTRClusterNameForID(MTRClusterIDType clusterID)
 {{/zcl_clusters}}
 
         default:
-            result = [NSString stringWithFormat:@"<Unknown clusterID %d>", clusterID];
+            result = [NSString stringWithFormat:@"<Unknown clusterID %u>", clusterID];
             break;
     }
 
@@ -72,15 +72,15 @@ NSString * MTRAttributeNameForID(MTRClusterIDType clusterID, MTRAttributeIDType
 
 {{#if (isSupported (asUpperCamelCase label preserveAcronyms=true) isForIds=true)}}
             default:
-                result = [NSString stringWithFormat:@"<Unknown attributeID %d>", attributeID];
+                result = [NSString stringWithFormat:@"<Unknown attributeID %u>", attributeID];
                 break;
         }
         break;
 {{/if}}
 
 {{/zcl_clusters}}
         default:
-           result = [NSString stringWithFormat:@"<Unknown clusterID %d>", clusterID];
+           result = [NSString stringWithFormat:@"<Unknown clusterID %u>", clusterID];
            break;
         }
 
@@ -119,15 +119,15 @@ NSString * MTRAttributeNameForID(MTRClusterIDType clusterID, MTRAttributeIDType
 {{> commandIDs clusterName=label}}
 
             default:
-                result = [NSString stringWithFormat:@"<Unknown commandID %d>", commandID];
+                result = [NSString stringWithFormat:@"<Unknown commandID %u>", commandID];
                 break;
         }
         break;
 {{/if}}
 
 {{/zcl_clusters}}
         default:
-           result = [NSString stringWithFormat:@"<Unknown clusterID %d>", clusterID];
+           result = [NSString stringWithFormat:@"<Unknown clusterID %u>", clusterID];
            break;
         }
 
@@ -183,15 +183,15 @@ NSString * MTREventNameForID(MTRClusterIDType clusterID, MTREventIDType eventID)
 
 {{#if (isSupported (asUpperCamelCase label preserveAcronyms=true) isForIds=true)}}
             default:
-                result = [NSString stringWithFormat:@"<Unknown eventID %d>", eventID];
+                result = [NSString stringWithFormat:@"<Unknown eventID %u>", eventID];
                 break;
         }
         break;
 {{/if}}
 
 {{/zcl_clusters}}
         default:
-           result = [NSString stringWithFormat:@"<Unknown clusterID %d>", clusterID];
+           result = [NSString stringWithFormat:@"<Unknown clusterID %u>", clusterID];
            break;
         }