Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Boris Zbarsky <[email protected]>
  • Loading branch information
mkardous-silabs and bzbarsky-apple committed Oct 19, 2023
1 parent 9b84021 commit 1dd0ada
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/messaging/ExchangeContext.h
Original file line number Diff line number Diff line change
Expand Up @@ -215,7 +215,7 @@ class DLL_EXPORT ExchangeContext : public ReliableMessageContext,
bool IsSendExpected() const { return mFlags.Has(Flags::kFlagWillSendMessage); }

/**
* Tracks if we have received at least one application level message
* Tracks whether we have received at least one application level message
* during the life-time of this exchange
*
* @return Returns 'true' if we have received at least one message, else 'false'
Expand Down
2 changes: 1 addition & 1 deletion src/messaging/tests/TestReliableMessageProtocol.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1574,7 +1574,7 @@ void TestReliableMessageProtocol::CheckIsPeerActiveNotInitiator(nlTestSuite * in
{
/**
* This tests the following scenario:
* 1) A reliable message expecting a response is sent from the initiator to responder which is losts
* 1) A reliable message expecting a response is sent from the initiator to responder which is lost
* 2) Initiator resends the message at the IdleRetrans interval
* 3) Responder receives the message and sends a standalone ack
* 4) Responder sends a response and fails
Expand Down

0 comments on commit 1dd0ada

Please sign in to comment.