Skip to content

Commit

Permalink
Update pigweed, make android not use mapfiles (#28161)
Browse files Browse the repository at this point in the history
* Disable mapfile creation for android toolchains (too large and slow, not used)

* Bump pigweed up to support the new flag

* Make tracing compile

---------

Co-authored-by: Andrei Litvin <[email protected]>
  • Loading branch information
2 people authored and pull[bot] committed Aug 1, 2023
1 parent 185fa97 commit 1988178
Show file tree
Hide file tree
Showing 9 changed files with 12 additions and 8 deletions.
2 changes: 1 addition & 1 deletion build/toolchain/android/android_toolchain.gni
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ template("android_clang_toolchain") {
_android_toolchain_args = {
current_os = "android"
is_clang = true

forward_variables_from(_invoker_toolchain_args, "*")
}

Expand Down Expand Up @@ -70,5 +69,6 @@ template("android_clang_toolchain") {
ar = _ndk_prefix + "llvm-ar"
cc = _ndk_prefix + _tool_name_root + "clang"
cxx = _ndk_prefix + _tool_name_root + "clang++"
link_generate_map_file = false
}
}
4 changes: 4 additions & 0 deletions build/toolchain/gcc_toolchain.gni
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,10 @@ template("gcc_toolchain") {
cxx = invoker.cxx
}

if (defined(invoker.link_generate_map_file)) {
link_generate_map_file = invoker.link_generate_map_file
}

is_host_toolchain = invoker_toolchain_args.current_os == host_os
link_group = invoker_toolchain_args.current_os != "mac" &&
invoker_toolchain_args.current_os != "ios"
Expand Down
2 changes: 1 addition & 1 deletion examples/platform/bouffalolab/common/rpc/Rpc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -168,7 +168,7 @@ Thread thread;
#endif // defined(PW_RPC_THREAD_SERVICE) && PW_RPC_THREAD_SERVICE

#if defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE
pw::trace::TraceService trace_service;
pw::trace::TraceService trace_service(pw::trace::GetTokenizedTracer());
#endif // defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE

void RegisterServices(pw::rpc::Server & server)
Expand Down
2 changes: 1 addition & 1 deletion examples/platform/esp32/Rpc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ Locking locking;
#endif // defined(PW_RPC_LOCKING_SERVICE) && PW_RPC_LOCKING_SERVICE

#if defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE
pw::trace::TraceService trace_service;
pw::trace::TraceService trace_service(pw::trace::GetTokenizedTracer());
#endif // defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE

#if defined(PW_RPC_WIFI_SERVICE) && PW_RPC_WIFI_SERVICE
Expand Down
2 changes: 1 addition & 1 deletion examples/platform/linux/Rpc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,7 @@ Lighting lighting_service;
#endif // defined(PW_RPC_LIGHTING_SERVICE) && PW_RPC_LIGHTING_SERVICE

#if defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE
pw::trace::TraceService trace_service;
pw::trace::TraceService trace_service(pw::trace::GetTokenizedTracer());
#endif // defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE

void RegisterServices(pw::rpc::Server & server)
Expand Down
2 changes: 1 addition & 1 deletion examples/platform/nrfconnect/Rpc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Thread thread;
#endif // defined(PW_RPC_THREAD_SERVICE) && PW_RPC_THREAD_SERVICE

#if defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE
pw::trace::TraceService trace_service;
pw::trace::TraceService trace_service(pw::trace::GetTokenizedTracer());
#endif // defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE

void RegisterServices(pw::rpc::Server & server)
Expand Down
2 changes: 1 addition & 1 deletion examples/platform/silabs/Rpc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ Thread thread;
#endif // defined(PW_RPC_THREAD_SERVICE) && PW_RPC_THREAD_SERVICE

#if defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE
pw::trace::TraceService trace_service;
pw::trace::TraceService trace_service(pw::trace::GetTokenizedTracer());
#endif // defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE

void RegisterServices(pw::rpc::Server & server)
Expand Down
2 changes: 1 addition & 1 deletion examples/platform/telink/Rpc.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ Thread thread;
#endif // defined(PW_RPC_THREAD_SERVICE) && PW_RPC_THREAD_SERVICE

#if defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE
pw::trace::TraceService trace_service;
pw::trace::TraceService trace_service(pw::trace::GetTokenizedTracer());
#endif // defined(PW_RPC_TRACING_SERVICE) && PW_RPC_TRACING_SERVICE

void RegisterServices(pw::rpc::Server & server)
Expand Down
2 changes: 1 addition & 1 deletion third_party/pigweed/repo
Submodule repo updated 320 files

0 comments on commit 1988178

Please sign in to comment.