Skip to content

Commit

Permalink
Fix typos in boostrap.sh comments, stop using path as a variable name (
Browse files Browse the repository at this point in the history
…#32944)

* Fix typos in boostrap.sh comments

* Rename path to submodule_path
  • Loading branch information
andy31415 authored and pull[bot] committed May 24, 2024
1 parent c2cc60f commit 1610428
Showing 1 changed file with 6 additions and 6 deletions.
12 changes: 6 additions & 6 deletions scripts/setup/bootstrap.sh
Original file line number Diff line number Diff line change
Expand Up @@ -57,19 +57,19 @@ _install_additional_pip_requirements() {
}

_submodules_need_updating() {
# Validates if a set o submodules that should always be checked out are up to date
# Validates if a set of submodules that should always be checked out are up to date.

# Pigweed will be up to date on an initial setup, however it may change over time
# the rest are a small subset of things that are always checked out (have no platform attachment)
# Pigweed will be up to date on an initial setup, however it may change over time.
# The rest are a small subset of things that are always checked out (have no platform attachment).
_SUBMODULE_PATHS=(
"third_party/pigweed/repo"
"third_party/openthread/repo"
"third_party/editline/repo"
)

for path in "${_SUBMODULE_PATHS[@]}"; do
if git submodule status "$path" | grep -E '^-' >/dev/null 2>&1; then
echo "git shows that $path has changes"
for submodule_path in "${_SUBMODULE_PATHS[@]}"; do
if git submodule status "$submodule_path" | grep -E '^-' >/dev/null 2>&1; then
echo "git shows that $submodule_path has changes"
unset _SUBMODULE_PATHS
return 0 # Success
fi
Expand Down

0 comments on commit 1610428

Please sign in to comment.