Skip to content

Commit

Permalink
Increase the test waits for timed interaction tests. (#12558)
Browse files Browse the repository at this point in the history
The tests are failing intermittently because the client starts the
wait when it _sends_ the message and the server starts its timer when
it _receives_ the message.  So if the message takes >5ms to be
delivered initially, the test ends up with an unexpectedly successful
command.

The right fix for this would be for the client to start its delay when
it receives the status response, but that requires more hooks into the
IM state machine than we have (and probably than we want).  For now,
just increase the timeout used by the client to make it very unlikely
that that much time passes before the timer on the server expires.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Oct 27, 2023
1 parent 4cc2413 commit 1468008
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
4 changes: 2 additions & 2 deletions src/app/tests/suites/TestClusterComplexTypes.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ tests:
timedInteractionTimeoutMs: 1
# Try to ensure that we are unresponsive for long enough that the timeout
# expires.
busyWaitMs: 5
busyWaitMs: 100
response:
error: UNSUPPORTED_ACCESS

Expand All @@ -81,6 +81,6 @@ tests:
timedInteractionTimeoutMs: 1
# Try to ensure that we are unresponsive for long enough that the timeout
# expires.
busyWaitMs: 5
busyWaitMs: 100
response:
error: UNSUPPORTED_ACCESS
8 changes: 4 additions & 4 deletions zzz_generated/chip-tool/zap-generated/test/Commands.h

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

0 comments on commit 1468008

Please sign in to comment.