Skip to content

Commit

Permalink
Align naming in Door Lock cluster XML with the spec. (#24358)
Browse files Browse the repository at this point in the history
* Align naming in Door Lock cluster XML with the spec.

* Auto-update ZAP files.

* Regenerate generated code.
  • Loading branch information
bzbarsky-apple authored and pull[bot] committed Sep 25, 2023
1 parent 5b99023 commit 1425482
Show file tree
Hide file tree
Showing 102 changed files with 6,069 additions and 5,623 deletions.
266 changes: 133 additions & 133 deletions examples/all-clusters-app/all-clusters-common/all-clusters-app.matter

Large diffs are not rendered by default.

Original file line number Diff line number Diff line change
Expand Up @@ -6221,7 +6221,7 @@
"code": 3,
"mfgCode": null,
"side": "server",
"type": "DlDoorState",
"type": "DoorStateEnum",
"included": 0,
"storageOption": "RAM",
"singleton": 0,
Expand Down Expand Up @@ -6301,7 +6301,7 @@
"code": 37,
"mfgCode": null,
"side": "server",
"type": "DlOperatingMode",
"type": "OperatingModeEnum",
"included": 0,
"storageOption": "RAM",
"singleton": 0,
Expand Down Expand Up @@ -13031,7 +13031,7 @@
"code": 3,
"mfgCode": null,
"side": "server",
"type": "DlDoorState",
"type": "DoorStateEnum",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
Expand Down Expand Up @@ -13351,7 +13351,7 @@
"code": 37,
"mfgCode": null,
"side": "server",
"type": "DlOperatingMode",
"type": "OperatingModeEnum",
"included": 1,
"storageOption": "RAM",
"singleton": 0,
Expand Down Expand Up @@ -22985,7 +22985,7 @@
"code": 3,
"mfgCode": null,
"side": "server",
"type": "DlDoorState",
"type": "DoorStateEnum",
"included": 0,
"storageOption": "RAM",
"singleton": 0,
Expand Down Expand Up @@ -23065,7 +23065,7 @@
"code": 37,
"mfgCode": null,
"side": "server",
"type": "DlOperatingMode",
"type": "OperatingModeEnum",
"included": 0,
"storageOption": "RAM",
"singleton": 0,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,16 @@ LOG_MODULE_DECLARE(app, CONFIG_CHIP_APP_LOG_LEVEL);

// Provided some empty callbacks and replaced feature map
// to simulate DoorLock endpoint for All-Clusters-App example
// without using kUsersManagement|kAccessSchedules|kRFIDCredentials|kPINCredentials
// without using kUser|kAccessSchedules|kRfidCredential|kPinCredential

bool emberAfPluginDoorLockOnDoorLockCommand(chip::EndpointId endpointId, const Optional<ByteSpan> & pinCode, DlOperationError & err)
bool emberAfPluginDoorLockOnDoorLockCommand(chip::EndpointId endpointId, const Optional<ByteSpan> & pinCode,
OperationErrorEnum & err)
{
return true;
}

bool emberAfPluginDoorLockOnDoorUnlockCommand(chip::EndpointId endpointId, const Optional<ByteSpan> & pinCode,
DlOperationError & err)
OperationErrorEnum & err)
{
return true;
}
Expand All @@ -48,7 +49,7 @@ void emberAfDoorLockClusterInitCallback(EndpointId endpoint)
DoorLockServer::Instance().InitServer(endpoint);

// Set FeatureMap to 0, default is:
// (kUsersManagement|kAccessSchedules|kRFIDCredentials|kPINCredentials) 0x113
// (kUser|kAccessSchedules|kRfidCredential|kPinCredential) 0x113
EmberAfStatus status = DoorLock::Attributes::FeatureMap::Set(endpoint, 0);
if (status != EMBER_ZCL_STATUS_SUCCESS)
{
Expand Down
9 changes: 5 additions & 4 deletions examples/all-clusters-app/telink/src/ZclDoorLockCallbacks.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -30,15 +30,16 @@ LOG_MODULE_DECLARE(app, CONFIG_MATTER_LOG_LEVEL);

// Provided some empty callbacks and replaced feature map
// to simulate DoorLock endpoint for All-Clusters-App example
// without using kUsersManagement|kAccessSchedules|kRFIDCredentials|kPINCredentials
// without using kUser|kAccessSchedules|kRfidCredential|kPinCredential

bool emberAfPluginDoorLockOnDoorLockCommand(chip::EndpointId endpointId, const Optional<ByteSpan> & pinCode, DlOperationError & err)
bool emberAfPluginDoorLockOnDoorLockCommand(chip::EndpointId endpointId, const Optional<ByteSpan> & pinCode,
OperationErrorEnum & err)
{
return true;
}

bool emberAfPluginDoorLockOnDoorUnlockCommand(chip::EndpointId endpointId, const Optional<ByteSpan> & pinCode,
DlOperationError & err)
OperationErrorEnum & err)
{
return true;
}
Expand All @@ -48,7 +49,7 @@ void emberAfDoorLockClusterInitCallback(EndpointId endpoint)
DoorLockServer::Instance().InitServer(endpoint);

// Set FeatureMap to 0, default is:
// (kUsersManagement|kAccessSchedules|kRFIDCredentials|kPINCredentials) 0x113
// (kUser|kAccessSchedules|kRfidCredential|kPinCredential) 0x113
EmberAfStatus status = DoorLock::Attributes::FeatureMap::Set(endpoint, 0);
if (status != EMBER_ZCL_STATUS_SUCCESS)
{
Expand Down
Loading

0 comments on commit 1425482

Please sign in to comment.