Bug/air quality sensor app leak (#28619)

* free handle on error * corrected README.md * Restyled by prettier-markdown * updated readme * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <[email protected]>
project-chip · Oct 24, 2023 · 1031936 · 1031936
1 parent 2a617a6
commit 1031936
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 6 deletions.
diff --git a/examples/air-quality-sensor-app/linux/AirQualitySensorAppAttrUpdateDelegate.cpp b/examples/air-quality-sensor-app/linux/AirQualitySensorAppAttrUpdateDelegate.cpp
@@ -106,7 +106,10 @@ void AirQualitySensorAttrUpdateHandler::HandleCommand(intptr_t context)
     auto * self             = reinterpret_cast<AirQualitySensorAttrUpdateHandler *>(context);
     std::string clusterName = self->mJsonValue["Name"].asString();
 
-    VerifyOrReturn(!self->mJsonValue.empty(), ChipLogError(NotSpecified, "Invalid JSON event command received"));
+    VerifyOrReturn(!self->mJsonValue.empty(), {
+        ChipLogError(NotSpecified, "Invalid JSON event command received");
+        Platform::Delete(self);
+    });
 
     if (clusterName == "AirQuality")
     {

diff --git a/examples/air-quality-sensor-app/linux/README.md b/examples/air-quality-sensor-app/linux/README.md
@@ -116,30 +116,30 @@ To cross-compile this example on x64 host and run on **NXP i.MX 8M Mini**
 ## Trigger event using air-quality-sensor-app event named pipe
 
 You can send a command to air-quality-sensor-app to trigger specific event via
-air-quality-sensor-app event named pipe /tmp/chip_air_quality_fifo-<PID>.
+air-quality-sensor-app event named pipe /tmp/chip_air_quality_fifo\*<PID>.
 
 ### Trigger air quality change event
 
 Generate event `AirQuality`, to change the air quality value.
 
 ```
-$ echo '{"Name":"AirQuality","NewValue":3}' > /tmp/chip_air_quality_fifo-<PID>
+$ echo '{"Name":"AirQuality","NewValue":3}' > /tmp/chip_air_quality_fifo_<PID>
 ```
 
 ### Trigger Temperature change event
 
 Generate event `TemperatureMeasurement`, to change the temperate value.
 
 ```
-$ echo '{"Name":"TemperatureMeasurement","NewValue":18}' > /tmp/chip_air_quality_fifo-<PID>
+$ echo '{"Name":"TemperatureMeasurement","NewValue":18}' > /tmp/chip_air_quality_fifo_<PID>
 ```
 
 ### Trigger Humidity change event
 
 Generate event `RelativeHumidityMeasurement`, to change the temperate value.
 
 ```
-$ echo '{"Name":"RelativeHumidityMeasurement","NewValue":60}' > /tmp/chip_air_quality_fifo-<PID>
+$ echo '{"Name":"RelativeHumidityMeasurement","NewValue":60}' > /tmp/chip_air_quality_fifo_<PID>
 ```
 
 ### Trigger concentration change event
@@ -150,5 +150,5 @@ clusters.
 Generate event `CarbonDioxideConcentrationMeasurement`, to change the CO2 value.
 
 ```
-$ echo '{"Name":"CarbonDioxideConcentrationMeasurement","NewValue":400}' > /tmp/chip_air_quality_fifo-<PID>
+$ echo '{"Name":"CarbonDioxideConcentrationMeasurement","NewValue":400}' > /tmp/chip_air_quality_fifo_<PID>
 ```