Skip to content

Commit

Permalink
[nrfconnect] Moved nlio target include to the common CMakeLists (#15907)
Browse files Browse the repository at this point in the history
The nlio repo is not included in the shell build, what may result
in build failures.

Moved nlio target include from examples' CMakeLists.txt files
to common for all nrfconnect examples chip-module CMakeLists.txt.
  • Loading branch information
kkasperczyk-no authored and pull[bot] committed Nov 14, 2023
1 parent ba6d9b0 commit 1031398
Show file tree
Hide file tree
Showing 6 changed files with 1 addition and 10 deletions.
1 change: 1 addition & 0 deletions config/nrfconnect/chip-module/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ target_include_directories(chip INTERFACE
${CHIP_ROOT}/src/include
${CHIP_ROOT}/src/lib
${CHIP_ROOT}/third_party/nlassert/repo/include
${CHIP_ROOT}/third_party/nlio/repo/include
${CHIP_ROOT}/zzz_generated/app-common
${CMAKE_CURRENT_BINARY_DIR}/gen/include
)
Expand Down
2 changes: 0 additions & 2 deletions examples/all-clusters-app/nrfconnect/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
cmake_minimum_required(VERSION 3.13.1)

get_filename_component(CHIP_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/third_party/connectedhomeip REALPATH)
get_filename_component(NLIO_ROOT ${CHIP_ROOT}/third_party/nlio/repo/include REALPATH)
get_filename_component(NRFCONNECT_COMMON ${CHIP_ROOT}/examples/platform/nrfconnect REALPATH)
get_filename_component(GEN_DIR ${CHIP_ROOT}/zzz_generated/ REALPATH)
get_filename_component(ALL_CLUSTERS_COMMON_DIR ${CHIP_ROOT}/examples/all-clusters-app/all-clusters-common REALPATH)
Expand Down Expand Up @@ -63,7 +62,6 @@ target_include_directories(app PRIVATE
${ALL_CLUSTERS_COMMON_DIR}/include
${GEN_DIR}/app-common
${GEN_DIR}/all-clusters-app
${NLIO_ROOT}
${NRFCONNECT_COMMON}/util/include)

target_sources(app PRIVATE
Expand Down
2 changes: 0 additions & 2 deletions examples/lighting-app/nrfconnect/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
cmake_minimum_required(VERSION 3.13.1)

get_filename_component(CHIP_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/third_party/connectedhomeip REALPATH)
get_filename_component(NLIO_ROOT ${CHIP_ROOT}/third_party/nlio/repo/include REALPATH)
get_filename_component(NRFCONNECT_COMMON ${CHIP_ROOT}/examples/platform/nrfconnect REALPATH)
get_filename_component(LIGHTING_COMMON ${CHIP_ROOT}/examples/lighting-app/lighting-common REALPATH)
get_filename_component(GEN_DIR ${CHIP_ROOT}/zzz_generated/ REALPATH)
Expand Down Expand Up @@ -82,7 +81,6 @@ target_include_directories(app PRIVATE
${GEN_DIR}
${GEN_DIR}/app-common
${GEN_DIR}/lighting-app
${NLIO_ROOT}
${NRFCONNECT_COMMON}/util/include
${NRFCONNECT_COMMON}/app/include)

Expand Down
2 changes: 0 additions & 2 deletions examples/lock-app/nrfconnect/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
cmake_minimum_required(VERSION 3.13.1)

get_filename_component(CHIP_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/third_party/connectedhomeip REALPATH)
get_filename_component(NLIO_ROOT ${CHIP_ROOT}/third_party/nlio/repo/include REALPATH)
get_filename_component(NRFCONNECT_COMMON ${CHIP_ROOT}/examples/platform/nrfconnect REALPATH)
get_filename_component(GEN_DIR ${CHIP_ROOT}/zzz_generated/ REALPATH)

Expand Down Expand Up @@ -74,7 +73,6 @@ target_include_directories(app PRIVATE
main/include
${GEN_DIR}/app-common
${GEN_DIR}/lock-app
${NLIO_ROOT}
${NRFCONNECT_COMMON}/util/include
${NRFCONNECT_COMMON}/app/include)

Expand Down
2 changes: 0 additions & 2 deletions examples/pump-app/nrfconnect/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
cmake_minimum_required(VERSION 3.13.1)

get_filename_component(CHIP_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/third_party/connectedhomeip REALPATH)
get_filename_component(NLIO_ROOT ${CHIP_ROOT}/third_party/nlio/repo/include REALPATH)
get_filename_component(NRFCONNECT_COMMON ${CHIP_ROOT}/examples/platform/nrfconnect REALPATH)
get_filename_component(GEN_DIR ${CHIP_ROOT}/zzz_generated/ REALPATH)

Expand Down Expand Up @@ -74,7 +73,6 @@ target_include_directories(app PRIVATE
main/include
${GEN_DIR}/app-common
${GEN_DIR}/pump-app
${NLIO_ROOT}
${NRFCONNECT_COMMON}/util/include
${NRFCONNECT_COMMON}/app/include)

Expand Down
2 changes: 0 additions & 2 deletions examples/pump-controller-app/nrfconnect/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@
cmake_minimum_required(VERSION 3.13.1)

get_filename_component(CHIP_ROOT ${CMAKE_CURRENT_SOURCE_DIR}/third_party/connectedhomeip REALPATH)
get_filename_component(NLIO_ROOT ${CHIP_ROOT}/third_party/nlio/repo/include REALPATH)
get_filename_component(NRFCONNECT_COMMON ${CHIP_ROOT}/examples/platform/nrfconnect REALPATH)
get_filename_component(GEN_DIR ${CHIP_ROOT}/zzz_generated/ REALPATH)

Expand Down Expand Up @@ -74,7 +73,6 @@ target_include_directories(app PRIVATE
main/include
${GEN_DIR}/app-common
${GEN_DIR}/pump-controller-app
${NLIO_ROOT}
${NRFCONNECT_COMMON}/util/include
${NRFCONNECT_COMMON}/app/include)

Expand Down

0 comments on commit 1031398

Please sign in to comment.