Skip to content

Commit

Permalink
Size reports: Change the highlight threshold. (#11061)
Browse files Browse the repository at this point in the history
#### Problem

Size reports comments should highlight a reasonable number of size
increases — enough to flag significant changes, but no so many that
they cause fatigue.

#### Change overview

Changed the threshold to 0.2%, which, based on recent commits,
should trigger on about 20% of PRs (not 20% of builds).

#### Testing

Offline runs on past data.
  • Loading branch information
kpschoedel authored and pull[bot] committed May 27, 2023
1 parent 86594a4 commit 1018756
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion .github/workflows/bloat_check.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ jobs:
run: |
scripts/tools/memory/gh_report.py \
--verbose \
--report-increases 1 \
--report-increases 0.2 \
--report-pr \
--github-comment \
--github-limit-artifact-pages 50 \
Expand Down

0 comments on commit 1018756

Please sign in to comment.