Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Make contains/excludes constraints compile for lists of unsigned valu…
…es. (#19730) Two changes here: 1) In chip_tests_iterate_expected_list, we were marking each individual value as an array (because "this.isArray" would be true in general when this helper is used). That caused asTypedLiteral to fail to map it to an integer basic type and hence we were not adding with the proper suffixes, and that lead to signed-to-unsigned comparison errors. This is the actual bugfix. 2) In asTypedLiteral, we really should be suffixing uint8_t with "U". It's not clear why compilers don't complain about signed-to-unsigned compares for that type the way they do for uint16/32/64_t, but conceptually this is the right thing to do. Fixes #19726
- Loading branch information