Merge branch 'master' into time_sync_trusted_time_source

.github/.wordlist.txt

@@ -154,6 +154,7 @@ blocklist
 blockquote
 bluetoothd
 bluez
+BOOL
 BooleanState
 bootable
 Bootloader
@@ -632,6 +633,7 @@ hci
 hciattach
 hciconfig
 hdlc
+HEPA
 HKDF
 HMAC
 hoc
@@ -641,7 +643,6 @@ HomePods
 hostapd
 hostname
 href
-HEPA
 HTTPS
 HW
 hwadr
@@ -652,6 +653,7 @@ IasWd
 iaszone
 ibb
 ICA
+ICD
 iCloud
 ICMP
 IDF

.github/actions/bootstrap/action.yaml

@@ -1,8 +1,13 @@
 name: Bootstrap
 description: Bootstrap
+inputs:
+  platform:
+    description: "Platform name"
+    required: false
+    default: none
 runs:
   using: "composite"
   steps:
     - name: Bootstrap
       shell: bash
-      run: bash scripts/bootstrap.sh
+      run: bash scripts/bootstrap.sh -p all,${{ inputs.platform }}

.github/actions/checkout-submodules-and-bootstrap/action.yaml

@@ -24,6 +24,8 @@ runs:
       uses: ./.github/actions/bootstrap-cache
     - name: Bootstrap
       uses: ./.github/actions/bootstrap
+      with:
+        platform: ${{ inputs.platform }}
     - name: Upload Bootstrap Logs
       uses: ./.github/actions/upload-bootstrap-logs
       with:

.github/issue-labeler.yml

@@ -1,8 +1,16 @@
 darwin:
-  - "(ios|homepod|darwin|mac|macos)"
+  # Make sure we don't match random words that contain "mac" inside.
+  #
+  # Make sure we don't match random words that contain "ios" inside
+  # (like "kiosk" or whatnot), but do allow matching "ios8" and things
+  # like that.
+  #
+  # \\b means "word boundary"
+  # (?![a-z]) means "there is no next char in the range a-z".
+  - "/(\\bios(?![a-z])|homepod|darwin|\\bmac\\b|macos)/i"
 
 linux:
-  - "(linux)"
+  - "/(linux)/i"
 
 # Special Keywords for Cert Blockers
 air purifiers:

.github/workflows/chef.yaml

@@ -54,7 +54,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build-esp32:1
+            image: ghcr.io/project-chip/chip-build-esp32:2
             options: --user root
 
         steps:
@@ -64,8 +64,6 @@ jobs:
               uses: ./.github/actions/checkout-submodules-and-bootstrap
               with:
                 platform: esp32
-            - name: Fixup GdbGui requirement
-              run: perl -i -pe 's/^gdbgui==/# gdbgui==/' /opt/espressif/esp-idf/requirements.txt
             - name: CI Examples ESP32
               shell: bash
               run: |

.github/workflows/darwin.yaml

@@ -95,10 +95,12 @@ jobs:
             - name: Build example OTA Provider
               run: |
                   scripts/examples/gn_build_example.sh examples/ota-provider-app/linux out/debug chip_config_network_layer_ble=false
-            - name: Build OTA image files with software version number 5
+            - name: Build OTA image files with software version number 5 and 10
               run: |
                   scripts/examples/gn_build_example.sh examples/ota-requestor-app/linux out/debug chip_config_network_layer_ble=false non_spec_compliant_ota_action_delay_floor=0 chip_device_config_device_software_version=5 chip_device_config_device_software_version_string='"5.0"'
-                  cp out/debug/chip-ota-requestor-app /tmp/ota-test005-raw-image
+                  cp out/debug/chip-ota-requestor-app /tmp/ota-raw-image-v5
+                  scripts/examples/gn_build_example.sh examples/ota-requestor-app/linux out/debug chip_config_network_layer_ble=false non_spec_compliant_ota_action_delay_floor=0 chip_device_config_device_software_version=10 chip_device_config_device_software_version_string='"10.0"'
+                  cp out/debug/chip-ota-requestor-app /tmp/ota-raw-image-v10
             - name: Build example OTA Requestor
               run: |
                   scripts/examples/gn_build_example.sh examples/ota-requestor-app/linux out/debug chip_config_network_layer_ble=false non_spec_compliant_ota_action_delay_floor=0
@@ -120,6 +122,7 @@ jobs:
                   # And a different port from the test harness too; the test harness uses port 5541.
                   ../../../out/debug/chip-ota-requestor-app --interface-id -1 --secured-device-port 5542 --discriminator 1111 --KVS /tmp/chip-ota-requestor-kvs1 --otaDownloadPath /tmp/chip-ota-requestor-downloaded-image1 --autoApplyImage > >(tee /tmp/darwin/framework-tests/ota-requestor-app-1.log) 2> >(tee /tmp/darwin/framework-tests/ota-requestor-app-err-1.log >&2) &
                   ../../../out/debug/chip-ota-requestor-app --interface-id -1 --secured-device-port 5543 --discriminator 1112 --KVS /tmp/chip-ota-requestor-kvs2 --otaDownloadPath /tmp/chip-ota-requestor-downloaded-image2 --autoApplyImage > >(tee /tmp/darwin/framework-tests/ota-requestor-app-2.log) 2> >(tee /tmp/darwin/framework-tests/ota-requestor-app-err-2.log >&2) &
+                  ../../../out/debug/chip-ota-requestor-app --interface-id -1 --secured-device-port 5544 --discriminator 1113 --KVS /tmp/chip-ota-requestor-kvs3 --otaDownloadPath /tmp/chip-ota-requestor-downloaded-image3 --autoApplyImage > >(tee /tmp/darwin/framework-tests/ota-requestor-app-3.log) 2> >(tee /tmp/darwin/framework-tests/ota-requestor-app-err-3.log >&2) &
                   # Disable BLE because the app does not have the permission to use
                   # it and that may crash the CI.
                   #

.github/workflows/examples-ameba.yaml

@@ -36,7 +36,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build-ameba:1
+            image: ghcr.io/project-chip/chip-build-ameba:4
             options: --user root
 
         steps:

.github/workflows/examples-efr32.yaml

@@ -61,19 +61,39 @@ jobs:
            scripts/examples/gn_silabs_example.sh examples/lighting-app/silabs ./out/light-app BRD4187C --slc_generate --docker
            scripts/examples/gn_silabs_example.sh examples/lighting-app/silabs ./out/light-app BRD4164A --slc_generate --docker
            rm -rf ./out/
-      - name: Build some BRD4187C variants
+      - name: Build some BRD4187C variants (1)
         run: |
           ./scripts/run_in_build_env.sh \
              "./scripts/build/build_examples.py \
                 --enable-flashbundle \
-                --target efr32-brd4187c-window-covering-additional_data_advertising \
                 --target efr32-brd4187c-thermostat-openthread_mtd \
-                --target efr32-brd4187c-switch-sed-shell-use_ot_coap_lib \
+                --target efr32-brd4187c-switch-shell-use_ot_coap_lib \
                 --target efr32-brd4187c-unit-test \
+                build \
+                --copy-artifacts-to out/artifacts \
+             "
+      - name: Clean out build output
+        run: rm -rf ./out
+      - name: Build some BRD4187C variants (2)
+        run: |
+          ./scripts/run_in_build_env.sh \
+             "./scripts/build/build_examples.py \
+                --enable-flashbundle \
                 --target efr32-brd4187c-light-use_ot_lib \
-                --target efr32-brd4187c-light-rpc \
                 --target efr32-brd4187c-pump \
-                --target efr32-brd4187c-lock-rpc-shell-enable_heap_monitoring \
+                --target efr32-brd4187c-lock-shell-enable_heap_monitoring \
+                build \
+                --copy-artifacts-to out/artifacts \
+             "
+      - name: Clean out build output
+        run: rm -rf ./out
+      - name: Build BRD4187C variants (3)
+        run: |
+          ./scripts/run_in_build_env.sh \
+             "./scripts/build/build_examples.py \
+                --enable-flashbundle \
+                --target efr32-brd4187c-window-covering-additional_data_advertising \
+                --target efr32-brd4187c-light-rpc \
                 build \
                 --copy-artifacts-to out/artifacts \
              "

.github/workflows/examples-esp32.yaml

@@ -34,7 +34,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build-esp32:1
+            image: ghcr.io/project-chip/chip-build-esp32:2
             volumes:
                 - "/tmp/bloat_reports:/tmp/bloat_reports"
 
@@ -46,9 +46,6 @@ jobs:
               with:
                 platform: esp32
 
-            - name: Fixup GdbGui requirement
-              run: perl -i -pe 's/^gdbgui==/# gdbgui==/' /opt/espressif/esp-idf/requirements.txt
-
             - name: Set up environment for size reports
               uses: ./.github/actions/setup-size-reports
               if: ${{ !env.ACT }}
@@ -110,12 +107,15 @@ jobs:
                      esp32 c3devkit all-clusters-app \
                      example_binaries/esp32-build/chip-all-clusters-app.elf \
                      /tmp/bloat_reports/
+
             - name: Build example Pigweed App
               run: scripts/examples/esp_example.sh pigweed-app sdkconfig.defaults
-            - name: Build example Lighting App
-              run: scripts/examples/esp_example.sh lighting-app sdkconfig.defaults
-            - name: Build example Lock App
-              run: scripts/examples/esp_example.sh lock-app sdkconfig.defaults
+
+            - name: Build example Lighting App (Target:ESP32H2)
+              run: scripts/examples/esp_example.sh lighting-app sdkconfig.defaults.esp32h2
+
+            - name: Build example Lock App (Target:ESP32C6)
+              run: scripts/examples/esp_example.sh lock-app sdkconfig.defaults.esp32c6
 
             - name: Uploading Size Reports
               uses: ./.github/actions/upload-size-reports
@@ -130,7 +130,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build-esp32:1
+            image: ghcr.io/project-chip/chip-build-esp32:2
             volumes:
                 - "/tmp/bloat_reports:/tmp/bloat_reports"
 
@@ -142,9 +142,6 @@ jobs:
               with:
                 platform: esp32
 
-            - name: Fixup GdbGui requirement
-              run: perl -i -pe 's/^gdbgui==/# gdbgui==/' /opt/espressif/esp-idf/requirements.txt
-
             - name: Build example Bridge App
               run: scripts/examples/esp_example.sh bridge-app
 
@@ -162,3 +159,6 @@ jobs:
 
             - name: Build example OTA Provider App
               run: scripts/examples/esp_example.sh ota-provider-app sdkconfig.defaults
+
+            - name: Build example Light Switch App (Target:ESP32C3)
+              run: scripts/examples/esp_example.sh light-switch-app sdkconfig.defaults.esp32c3

.github/workflows/examples-k32w.yaml

@@ -37,7 +37,7 @@ jobs:
         if: github.actor != 'restyled-io[bot]'
 
         container:
-            image: ghcr.io/project-chip/chip-build-k32w:1
+            image: ghcr.io/project-chip/chip-build-k32w:5
             volumes:
                 - "/tmp/bloat_reports:/tmp/bloat_reports"
         steps:

.github/workflows/examples-openiotsdk.yaml

@@ -72,6 +72,15 @@ jobs:
                     examples/shell/openiotsdk/build/chip-openiotsdk-shell-example.elf \
                     /tmp/bloat_reports/
 
+            - name: "Test: shell example"
+              if: steps.build_shell.outcome == 'success'
+              run: |
+                  scripts/run_in_python_env.sh out/venv \
+                    'scripts/examples/openiotsdk_example.sh --no-activate -C test shell'
+
+            - name: Clean shell output
+              run: rm -rf examples/shell/openiotsdk/build
+
             - name: Build lock-app example (mbedtls)
               # Disabled being tracked here: https://github.com/project-chip/connectedhomeip/issues/28026
               if: false
@@ -93,6 +102,18 @@ jobs:
                     examples/tv-app/openiotsdk/build/chip-openiotsdk-tv-app-example.elf \
                     /tmp/bloat_reports/
 
+            - name: "Test: tv-app example"
+              if: steps.build_tv_app.outcome == 'success'
+              timeout-minutes: 10
+              run: |
+                  scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME up
+                  scripts/run_in_python_env.sh out/venv \
+                    'scripts/run_in_ns.sh ${TEST_NETWORK_NAME}ns scripts/examples/openiotsdk_example.sh --no-activate -C test -n ${TEST_NETWORK_NAME}tap tv-app'
+                  scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME down
+
+            - name: Clean tv-app output
+              run: rm -rf examples/tv-app/openiotsdk/build
+
             - name: Build all-clusters-app example
               id: build_all_clusters_app
               timeout-minutes: 10
@@ -103,6 +124,18 @@ jobs:
                     examples/all-clusters-app/openiotsdk/build/chip-openiotsdk-all-clusters-app-example.elf \
                     /tmp/bloat_reports/
 
+            - name: "Test: all-clusters-app example"
+              if: steps.build_all_clusters_app.outcome == 'success'
+              timeout-minutes: 5
+              run: |
+                  scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME up
+                  scripts/run_in_python_env.sh out/venv \
+                    'scripts/run_in_ns.sh ${TEST_NETWORK_NAME}ns scripts/examples/openiotsdk_example.sh --no-activate -C test -n ${TEST_NETWORK_NAME}tap all-clusters-app'
+                  scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME down
+
+            - name: Clean all-clusters-app output
+              run: rm -rf examples/all-clusters-app/openiotsdk/build
+
             - name: Build ota-requestor-app example
               id: build_ota_requestor_app
               timeout-minutes: 10
@@ -127,12 +160,6 @@ jobs:
               run: |
                   scripts/examples/gn_build_example.sh examples/ota-provider-app/linux/ out/ota-provider chip_config_network_layer_ble=false
 
-            - name: "Test: shell example"
-              if: steps.build_shell.outcome == 'success'
-              run: |
-                  scripts/run_in_python_env.sh out/venv \
-                    'scripts/examples/openiotsdk_example.sh --no-activate -C test shell'
-
             - name: "Test: lock-app example (mbedtls)"
               if: steps.build_lock_app_mbedtls.outcome == 'success'
               run: |
@@ -141,24 +168,6 @@ jobs:
                     'scripts/run_in_ns.sh ${TEST_NETWORK_NAME}ns scripts/examples/openiotsdk_example.sh --no-activate -C test -n ${TEST_NETWORK_NAME}tap lock-app'
                   scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME down
 
-            - name: "Test: tv-app example"
-              if: steps.build_tv_app.outcome == 'success'
-              timeout-minutes: 10
-              run: |
-                  scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME up
-                  scripts/run_in_python_env.sh out/venv \
-                    'scripts/run_in_ns.sh ${TEST_NETWORK_NAME}ns scripts/examples/openiotsdk_example.sh --no-activate -C test -n ${TEST_NETWORK_NAME}tap tv-app'
-                  scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME down
-
-            - name: "Test: all-clusters-app example"
-              if: steps.build_all_clusters_app.outcome == 'success'
-              timeout-minutes: 5
-              run: |
-                  scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME up
-                  scripts/run_in_python_env.sh out/venv \
-                    'scripts/run_in_ns.sh ${TEST_NETWORK_NAME}ns scripts/examples/openiotsdk_example.sh --no-activate -C test -n ${TEST_NETWORK_NAME}tap all-clusters-app'
-                  scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME down
-
             - name: "Test: ota-requestor-app example"
               if: steps.build_ota_requestor_app.outcome == 'success' && steps.build_ota_provider_app.outcome == 'success'
               timeout-minutes: 30
@@ -189,11 +198,6 @@ jobs:
                     examples/lock-app/openiotsdk/build/chip-openiotsdk-lock-app-example.elf \
                     /tmp/bloat_reports/
 
-            - name: Build unit tests (psa)
-              id: build_unit_tests_psa
-              run: |
-                  scripts/examples/openiotsdk_example.sh -b psa unit-tests
-
             - name: "Test: lock-app example (psa)"
               if: steps.build_lock_app_psa.outcome == 'success'
               run: |
@@ -202,6 +206,11 @@ jobs:
                     'scripts/run_in_ns.sh ${TEST_NETWORK_NAME}ns scripts/examples/openiotsdk_example.sh --no-activate -C test -n ${TEST_NETWORK_NAME}tap lock-app'
                   scripts/setup/openiotsdk/network_setup.sh -n $TEST_NETWORK_NAME down
 
+            - name: Build unit tests (psa)
+              id: build_unit_tests_psa
+              run: |
+                  scripts/examples/openiotsdk_example.sh -b psa unit-tests
+
             - name: "Test: unit-tests (psa)"
               if: steps.build_unit_tests_psa.outcome == 'success'
               run: |

.github/workflows/kotlin-style.yaml

@@ -22,7 +22,7 @@ jobs:
         uses: actions/checkout@v3
 
       - name: "detekt"
-        uses: natiginfo/[email protected].0
+        uses: natiginfo/[email protected].1
         # Detekt seems not to like circular symlinks, so we set up
         # explicit paths below
         with:

.github/workflows/minimal-build.yaml

@@ -36,10 +36,12 @@ jobs:
         steps:
             - name: Checkout
               uses: actions/checkout@v3
-            - name: Checkout submodules & Bootstrap
-              uses: ./.github/actions/checkout-submodules-and-bootstrap
+
+            - name: Checkout submodules # but don't bootstrap!
+              uses: ./.github/actions/checkout-submodules
               with:
                 platform: linux
+
             - name: Configure and build All Clusters App
               run: |
                   CC=gcc CXX=g++ scripts/configure --project=examples/all-clusters-app/linux && ./ninja-build