Skip to content

Commit

Permalink
Fix signatures of string-attribute getters in Accessors.h/cpp. (#29029)
Browse files Browse the repository at this point in the history
The old signature did not propagate the update length of the span to the caller.

This is a manual backport of #29024.

The ZAP update is needed to get the right output.

This modifies a few things, which were included in the PR so that the ZAP job
would pass.

The Darwin bits might not compile in this state, but that's OK.
  • Loading branch information
bzbarsky-apple authored Sep 5, 2023
1 parent eb23187 commit 06a421e
Show file tree
Hide file tree
Showing 28 changed files with 58,638 additions and 29,184 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2102,7 +2102,7 @@ endpoint 0 {
}
}
endpoint 1 {
device type extendedcolorlight = 269, version 1;
device type extendedcolorlight = 257, version 1;

server cluster Identify {
ram attribute identifyTime default = 0x0000;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -1963,7 +1963,7 @@ endpoint 0 {
}
}
endpoint 1 {
device type extendedcolorlight = 269, version 1;
device type extendedcolorlight = 257, version 1;

server cluster Identify {
ram attribute identifyTime default = 0x0000;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -475,6 +475,7 @@ server cluster OperationalCredentials = 62 {
}

endpoint 0 {
device type anonymousEndpointType = 0, version 1;
binding cluster DiagnosticLogs;

server cluster AccessControl {
Expand Down
1 change: 0 additions & 1 deletion examples/placeholder/linux/apps/app1/config.matter
Original file line number Diff line number Diff line change
Expand Up @@ -3391,7 +3391,6 @@ server cluster ApplicationBasic = 1293 {
}

endpoint 0 {
device type anonymousEndpointType = 65280, version 1;
binding cluster OnOff;
binding cluster GeneralCommissioning;
binding cluster Switch;
Expand Down
1 change: 0 additions & 1 deletion examples/placeholder/linux/apps/app2/config.matter
Original file line number Diff line number Diff line change
Expand Up @@ -3352,7 +3352,6 @@ server cluster ApplicationBasic = 1293 {
}

endpoint 0 {
device type anonymousEndpointType = 65280, version 1;
binding cluster OnOff;
binding cluster GeneralCommissioning;
binding cluster Switch;
Expand Down
2 changes: 1 addition & 1 deletion integrations/docker/images/chip-cert-bins/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ ARG COMMITHASH=7b99e6399c6069037c613782d78132c69b9dcabb
# ZAP Development install, so that it runs on both x64 and arm64
# Generally this should match with the ZAP version that is used for codegen within the
# specified SHA
ARG ZAP_VERSION=v2023.04.27-nightly
ARG ZAP_VERSION=v2023.09.01-nightly

# Ensure TARGETPLATFORM is set
RUN case ${TARGETPLATFORM} in \
Expand Down
2 changes: 1 addition & 1 deletion scripts/setup/zap.json
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"mac-arm64",
"windows-amd64"
],
"tags": ["version:2@v2023.04.27-nightly.1"]
"tags": ["version:2@v2023.09.01-nightly.1"]
}
]
}
2 changes: 1 addition & 1 deletion scripts/tools/zap/zap_execution.py
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
# Use scripts/tools/zap/version_update.py to manage ZAP versioning as many
# files may need updating for versions
#
MIN_ZAP_VERSION = '2023.4.27'
MIN_ZAP_VERSION = '2023.9.1'


class ZapTool:
Expand Down
6 changes: 6 additions & 0 deletions src/darwin/Framework/CHIP/MTRDefines.h
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,12 @@
#define MTR_NEWLY_AVAILABLE
#endif

#if defined(MTR_ENABLE_PROVISIONAL) && MTR_ENABLE_PROVISIONAL
#define MTR_PROVISIONALLY_AVAILABLE MTR_NEWLY_AVAILABLE
#else
#define MTR_PROVISIONALLY_AVAILABLE NS_UNAVAILABLE MTR_HIDDEN
#endif

#pragma mark - Types

typedef NSData * MTRTLVBytes;
Expand Down
Loading

0 comments on commit 06a421e

Please sign in to comment.