-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Allow SetGroupDataProvider(nullptr) for resource mgmt (#17408)
- Users implementing clean system shutdown must ensure that once they release their GroupDataProvider, the implementation does not dangle. After proper shutdown, GetGroupDataProvider() will never be called again, so it's fine to set it to nullptr. If it is indeed called, then next access will crash will null pointer dereference, which is more deterministic than use-after-free that would occur today. - Allow setting GroupDataProvider singleton to nullptr Testing done: - Unit tests pass - Integration tests pass
- Loading branch information
1 parent
737b702
commit 0680f21
Showing
2 changed files
with
4 additions
and
23 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters