Skip to content

Commit

Permalink
Apply comment suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Boris Zbarsky <[email protected]>
  • Loading branch information
ksperling-apple and bzbarsky-apple authored Jun 27, 2024
1 parent 42570fa commit 065118f
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/app/ReadClient.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -462,7 +462,7 @@ CHIP_ERROR ReadClient::GenerateDataVersionFilterList(DataVersionFilterIBs::Build
const Span<DataVersionFilter> & aDataVersionFilters,
bool & aEncodedDataVersionList)
{
// Give the callback a chance first, otherwise use the list we have.
// Give the callback a chance first, otherwise use the list we have, if any.
ReturnErrorOnFailure(
mpCallback.OnUpdateDataVersionFilterList(aDataVersionFilterIBsBuilder, aAttributePaths, aEncodedDataVersionList));

Expand Down
2 changes: 1 addition & 1 deletion src/app/ReadClient.h
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ class ReadClient : public Messaging::ExchangeDelegate
* This will send either a Read Request or a Subscribe Request depending on
* the InteractionType this read client was initialized with.
*
* If the requests contains more data version filters than can fit in the request packet
* If the params contain more data version filters than can fit in the request packet
* the list will be truncated as needed, i.e. filter inclusion is on a best effort basis.
*
* @retval #others fail to send read request
Expand Down

0 comments on commit 065118f

Please sign in to comment.