Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: Boris Zbarsky <[email protected]>
  • Loading branch information
nivi-apple and bzbarsky-apple authored Jul 29, 2024
1 parent 0147c71 commit 05fc602
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ CHIP_ERROR PresetStructWithOwnedMembers::SetPresetHandle(const Nullable<ByteSpan
if (newPresetHandleSize > kPresetHandleSize)
{
ChipLogError(Zcl, "Failed to set Preset handle. New preset handle size (%u) > allowed preset handle size (%u)",
static_cast<uint8_t>(newPresetHandleSize), static_cast<uint8_t>(kPresetNameSize));
static_cast<unsigned>(newPresetHandleSize), static_cast<unsigned>(kPresetNameSize));
return CHIP_ERROR_NO_MEMORY;
}
MutableByteSpan targetSpan(presetHandleData);
Expand Down
2 changes: 1 addition & 1 deletion src/app/clusters/thermostat-server/thermostat-server.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -1510,7 +1510,7 @@ bool emberAfThermostatClusterCommitPresetsSchedulesRequestCallback(
return SendResponseAndCleanUp(delegate, endpoint, commandObj, commandPath, imcode::ConstraintError);
}

// If the preset type for the preset scenario does not support name and a name is specified, return CONSTRAINT_ERROR.
// If the preset type for the preset scenario does not support names and a name is specified, return CONSTRAINT_ERROR.
if (!PresetTypeSupportsNames(delegate, presetScenario) && pendingPreset.GetName().HasValue())
{
return SendResponseAndCleanUp(delegate, endpoint, commandObj, commandPath, imcode::ConstraintError);
Expand Down

0 comments on commit 05fc602

Please sign in to comment.