Skip to content

Commit

Permalink
Address PR comment
Browse files Browse the repository at this point in the history
  • Loading branch information
tehampson committed Jun 6, 2024
1 parent 65d9dca commit 02da318
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 3 deletions.
3 changes: 2 additions & 1 deletion src/app/CommandSender.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,8 @@ CHIP_ERROR CommandSender::FinishCommand(FinishCommandParameters & aFinishCommand
return FinishCommandInternal(aFinishCommandParams);
}

CHIP_ERROR CommandSender::AddRequestDataInternal(const CommandPathParams & aCommandPath, DataModel::EncodableToTLV & aEncodable,
CHIP_ERROR CommandSender::AddRequestDataInternal(const CommandPathParams & aCommandPath,
const DataModel::EncodableToTLV & aEncodable,
AddRequestDataParameters & aAddRequestDataParams)
{
PrepareCommandParameters prepareCommandParams(aAddRequestDataParams);
Expand Down
5 changes: 3 additions & 2 deletions src/app/CommandSender.h
Original file line number Diff line number Diff line change
Expand Up @@ -390,7 +390,7 @@ class CommandSender final : public Messaging::ExchangeDelegate
* invoke interaction. If the caller wants that certainty they should call the templated
* version of AddRequestData.
*/
CHIP_ERROR AddRequestData(const CommandPathParams & aCommandPath, DataModel::EncodableToTLV & aEncodable,
CHIP_ERROR AddRequestData(const CommandPathParams & aCommandPath, const DataModel::EncodableToTLV & aEncodable,
AddRequestDataParameters & aAddRequestDataParams)
{
return AddRequestDataInternal(aCommandPath, aEncodable, aAddRequestDataParams);
Expand Down Expand Up @@ -473,7 +473,8 @@ class CommandSender final : public Messaging::ExchangeDelegate
#endif // CONFIG_BUILD_FOR_HOST_UNIT_TEST

private:
CHIP_ERROR AddRequestDataInternal(const CommandPathParams & aCommandPath, DataModel::EncodableToTLV & aEncodable,
CHIP_ERROR AddRequestDataInternal(const CommandPathParams & aCommandPath,
const DataModel::EncodableToTLV & aEncodable,
AddRequestDataParameters & aAddRequestDataParams);

CHIP_ERROR FinishCommandInternal(FinishCommandParameters & aFinishCommandParams);
Expand Down

0 comments on commit 02da318

Please sign in to comment.