Add support for configuring terms and conditions in device commissioning #173
Conversation
This commit introduces a new `enhanced_setup_flow` configuration property to the test harness backend, allowing device manufacturers to define the terms and conditions (T&C) that must be acknowledged and set during device commissioning. These values are critical for supporting the Terms and Conditions Certification Test Suite. Key changes include: - Added the `EnhancedSetupFlowConfig` class to `DutConfig`, which allows specifying the T&C version and user response required during commissioning. - Updated `generate_command_arguments` in `utils.py` to append the necessary arguments for T&C validation and the device's commissioning method. - Adjusted model validation to ensure the `enhanced_setup_flow` field is processed correctly within `DutConfig`. These changes ensure the test harness can enforce manufacturer-specific T&C values during the commissioning process, aligning with the broader requirements of T&C validation.
test_collections/matter/sdk_tests/support/performance_tests/utils.py
Outdated
Show resolved
Hide resolved
test_collections/matter/sdk_tests/support/python_testing/__init__.py
Outdated
Show resolved
Hide resolved
test_collections/matter/sdk_tests/support/python_testing/models/utils.py
Outdated
Show resolved
Hide resolved
test_collections/matter/sdk_tests/support/python_testing/models/utils.py
Outdated
Show resolved
Hide resolved
|
Hi @swan-amazon I changed the target from |
Co-authored-by: Romulo Quidute Filho <[email protected]>
Hey @rquidute , I'm not sure why those spell checks weren't failing previously. I didn't add the words that it's flagging on now... I was asking Raju but he didn't know. I asked if something was recently enabled and he doesn't think so. What should we do? |
Co-authored-by: Romulo Quidute Filho <[email protected]>
…ils.py Co-authored-by: Romulo Quidute Filho <[email protected]>
…s/utils.py Co-authored-by: Romulo Quidute Filho <[email protected]>
…s/utils.py Co-authored-by: Romulo Quidute Filho <[email protected]>
…t__.py Co-authored-by: Romulo Quidute Filho <[email protected]>
test_collections/matter/sdk_tests/support/performance_tests/utils.py
Outdated
Show resolved
Hide resolved
Hi @swan-amazon don't worry about spelling issue in this PR. There is still just one spelling issue, but this is a temp code. This is something we need to fix. |
…ce_tests/utils.py
…ning validation Add new parameter to control commissioning flow during tests, allowing manual validation of the commissioning process instead of auto-commissioning. This enables test cases to verify terms and conditions acknowledgements during the commissioning flow. - Add in-test-commissioning-method parameter to test flags - Support manual commissioning flow validation - Enable testing of T&C acknowledgement scenarios
This reverts commit 5d65ce5.
This reverts commit 2cd99b7.
This reverts commit 48c0e32.
This commit introduces a new
enhanced_setup_flowconfiguration property to the test harness backend, allowing device manufacturers to define the terms and conditions (T&C) that must be acknowledged and set during device commissioning. These values are critical for supporting the Terms and Conditions Certification Test Suite.Key changes include:
EnhancedSetupFlowConfigclass toDutConfig, which allows specifying the T&C version and user response required during commissioning.generate_command_argumentsinutils.pyto append the necessary arguments for T&C validation and the device's commissioning method.enhanced_setup_flowfield is processed correctly withinDutConfig.These changes ensure the test harness can enforce manufacturer-specific T&C values during the commissioning process, aligning with the broader requirements of T&C validation.