[FIX] Added support to negated PICS #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rquidute
changed the title
hiltonlima
approved these changes
Dec 2, 2024
rquidute
commented
Dec 2, 2024
ccruzagralopes
approved these changes
Dec 4, 2024
hiltonlima
pushed a commit
that referenced
this pull request
Dec 17, 2024
* Added support to negated PICS * Fixed flake * Code review. No consider negatives PICS * Update app/pics_applicable_test_cases.py * Code review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What Changed
Add support to consider Negative PICS, such as
!MCORE.DT_SW_COMPas description in image bellow:Related Issue
project-chip/certification-tool#320
Testing
TC with Negative PICS is now being considered.
For example, TC-BIND-2.1, which has the following PICS configuration is now being considered:
BIND.C: trueMCORE.ROLE.CONTROLLER: trueMCORE.DT_SW_COMP: falseUnit Testing passing
