Add TypeDef support, minor tweaks to XML output (to match XSD) #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with SemanticDiff. Analyzed 18 of 18 files. Overall, the semantic diff is 3% smaller than the GitHub diff.
|
…ng to simple types for better referenceability (e.g. for an ID which belongs to some non-global space)
gmarcosb
changed the title
gmarcosb
changed the title
|
@hasty to review, @bzbarsky-apple asked me to reach out regarding adding this support @ project-chip/connectedhomeip#35773 |
This was referenced Sep 26, 2024
hasty
reviewed
Sep 30, 2024
Missed this in conflict resolution
Co-authored-by: Hasty Granbery <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primary change is adding of TypeDef support
See for example
VideoStreamId@ https://github.com/CHIP-Specifications/connectedhomeip-spec/blob/a3ef8252366959537d75d4e32060d89ca18756f1/src/app_clusters/WebRTC_Provider.adocAnd resulting output with the updates here: https://github.com/project-chip/connectedhomeip/blob/45216a86c1178f94a29688d114263e87321e8352/src/app/zap-templates/zcl/data-model/chip/web-rtc-provider-cluster.xml
Minor tweaks: