Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistency improvements #749

Merged
merged 13 commits into from
Nov 22, 2024
Merged

Consistency improvements #749

merged 13 commits into from
Nov 22, 2024

Conversation

mkstoyanov
Copy link
Collaborator

@mkstoyanov mkstoyanov commented Nov 21, 2024 •
edited
Loading

  • improved the consistency of ASGARD_USE_HIGHFIVE as a CMake options name
  • moved the IO methods into a .cpp file and made the high-five headers private
  • bumped the catch version to avoid errors on newer compilers
  • removed and reorganized some old matlab functions

@mkstoyanov mkstoyanov force-pushed the consistency_improvements branch from 466465f to 93888dc Compare November 22, 2024 18:15
@mkstoyanov mkstoyanov merged commit 15edef9 into project-asgard:develop Nov 22, 2024
11 checks passed
@mkstoyanov mkstoyanov deleted the consistency_improvements branch November 22, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mkstoyanov