Block global kron cpu #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkstoyanov
force-pushed
the
block_global_kron_cpu
branch
2 times, most recently
from
627b8e5 to
b06e2b4
Compare
|
The block-global kronmult is faster than the original one so we will replace the old version but only after we get the GPU kernels. Right now, we need the extra CMake option |
Co-authored-by: Steven Hahn <[email protected]>
Co-authored-by: Steven Hahn <[email protected]>
Co-authored-by: Steven Hahn <[email protected]>
Co-authored-by: Steven Hahn <[email protected]>
Co-authored-by: Steven Hahn <[email protected]>
Co-authored-by: Steven Hahn <[email protected]>
Co-authored-by: Steven Hahn <[email protected]>
mkstoyanov
force-pushed
the
block_global_kron_cpu
branch
from
f347875 to
df836f0
Compare
quantumsteve
previously approved these changes
Jun 25, 2024
|
@quantumsteve Sorry but I put some pretty lines here and there, should be good for your re-review now. Nothing major has changed. |
quantumsteve
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Block-global kronmult will be used for interpolation.