Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes array indexing but may transpose figures #676

Closed

Conversation

quantumsteve
Copy link
Collaborator

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.

Fixes #675

What type(s) of changes does this code introduce?

Put an x in the boxes that apply.

  • Bugfix
  • New feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

What systems has this change been tested on?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • this PR is up to date with current the current state of 'develop'
  • code added or changed in the PR has been clang-formatted
  • this PR adds tests to cover any new code, or to catch a bug that is being fixed
  • documentation has been added (if appropriate)

@quantumsteve quantumsteve marked this pull request as draft March 19, 2024 13:56
@quantumsteve quantumsteve force-pushed the 675_fix_array_indexing branch from d80c3d2 to 228517a Compare March 19, 2024 16:42
@quantumsteve quantumsteve force-pushed the 675_fix_array_indexing branch from 95ab2bd to e0ea389 Compare March 20, 2024 21:10
@mkstoyanov
Copy link
Collaborator

@quantumsteve The BiCG is higher priority but if we're not going to get back to this one, then we should close it.

@quantumsteve
Copy link
Collaborator Author

Closing as the matlab interface is likely to be deprecated/removed and distributed gmres/bicgstab is a higher priority.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

two_stream throws exception with ASGARD_USE_MATLAB=ON
2 participants