Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure plots stay open and we don't get an exception #671

Merged
merged 3 commits into from
Mar 15, 2024

Conversation

quantumsteve
Copy link
Collaborator

@quantumsteve quantumsteve commented Mar 14, 2024

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.

What type(s) of changes does this code introduce?

Put an x in the boxes that apply.

  • Bugfix
  • New feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Does this introduce a breaking change?

  • Yes
  • No

What systems has this change been tested on?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

  • this PR is up to date with current the current state of 'develop'
  • code added or changed in the PR has been clang-formatted
  • this PR adds tests to cover any new code, or to catch a bug that is being fixed
  • documentation has been added (if appropriate)

@quantumsteve
Copy link
Collaborator Author

@stefan-schnake Is this something you can test?

@stefan-schnake
Copy link
Contributor

@stefan-schnake Is this something you can test?

I'll look into it today.

@stefan-schnake
Copy link
Contributor

@quantumsteve works for diffusion1

mkstoyanov
mkstoyanov previously approved these changes Mar 15, 2024
@quantumsteve quantumsteve merged commit e2b61dc into project-asgard:develop Mar 15, 2024
11 checks passed
@quantumsteve quantumsteve deleted the fix_matlab_again branch March 15, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants