gmres: fix array size and move initialization outside of outer loop

[quantumsteve]

Please review the developer documentation
on the wiki of this project that contains help and requirements.

Proposed changes

Describe what this PR changes and why. If it closes an issue, link to it here
with a supported keyword.

moved krylov_sol out of the outer loop, incrementally zeroing out the next element. Worked around a CUDA warning about no return and removed the uniform initialization Miro dislikes.

What type(s) of changes does this code introduce?

Put an x in the boxes that apply.

• Bugfix
• New feature
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no api changes)
• Build related changes
• Documentation content changes
• Other (please describe):

Does this introduce a breaking change?

• Yes
• No

What systems has this change been tested on?

Checklist

Put an x in the boxes that apply. You can also fill these out after creating
the PR. If you're unsure about any of them, don't hesitate to ask. This is
simply a reminder of what we are going to look for before merging your code.

• this PR is up to date with current the current state of 'develop'
• code added or changed in the PR has been clang-formatted
• this PR adds tests to cover any new code, or to catch a bug that is being fixed
• documentation has been added (if appropriate)

[mkstoyanov]

What's with the pending AWS run? Is there something wrong with the AWS setup?

[quantumsteve]

What's with the pending AWS run? Is there something wrong with the AWS setup?

Looks like we're hitting a 2 hour "queued timeout". I increased that value to 8 hours and am trying another build.

[mkstoyanov]

Another question is why are we waiting for so long? It does seem that AWS is overloaded, at least on the GPU front.