Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix issue with assertions in axpy #649

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix issue with assertions in axpy #649

merged 1 commit into from
Dec 11, 2023

Conversation

mkstoyanov
Copy link
Collaborator

Small problem I cam across.

quantumsteve
quantumsteve approved these changes Nov 28, 2023
View reviewed changes
Copy link
Collaborator

@quantumsteve quantumsteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When alpha == 0. is this just a copy?

@mkstoyanov
Copy link
Collaborator Author

When alpha == 0. is this just a copy?

No, it should be a no-op, the operation is y += alpha * x

@mkstoyanov mkstoyanov merged commit cb658d2 into project-asgard:develop Dec 11, 2023
1 check passed
@mkstoyanov mkstoyanov deleted the fix_libdispatch branch December 11, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@quantumsteve quantumsteve quantumsteve approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mkstoyanov @quantumsteve