sFlow HLD Document #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add draft of sFlow HLD for SONiC Management Framework. Signed-off-by: Garrick He <[email protected]>
* Update CLI command/example * Update UT descriptions Signed-off-by: Garrick He <[email protected]>
mikelazar
reviewed
Oct 2, 2019
| 1. Implement sFlow support using transformer in sonic-mgmt-framework | ||
|
|
||
| ### 1.2.2 Container | ||
| There will be changes in the sonic-mgmt-framework container |
There was a problem hiding this comment.
What are those changes ? Just TransLib code etc. or something else ?
jeff-yin
requested changes
Oct 2, 2019
* Update sflow CLI examples and corrections Signed-off-by: Garrick He <[email protected]>
* Update sFlow HLD to address review comments. Signed-off-by: Garrick He <[email protected]>
Signed-off-by: Garrick He <[email protected]>
* Address more review comments Signed-off-by: Garrick He <[email protected]>
jeff-yin
requested changes
Oct 14, 2019
| ##### Set sampling-rate | ||
| Syntax: | ||
|
|
||
| rate: [256 - 8388608] |
There was a problem hiding this comment.
I think you should specify the valid ranges for a parameter after the syntax specification.
* Add more information regarding agent-id and sample-rate default values * Add more information about SONiC sFlow YANG. Signed-off-by: Garrick He <[email protected]>
Signed-off-by: Garrick He <[email protected]>
jeff-yin
approved these changes
Oct 16, 2019
kkvedula
reviewed
Oct 23, 2019
kkvedula
reviewed
Oct 23, 2019
* Update the sFlow admin-state from enable/disable to up/down. Signed-off-by: Garrick He <[email protected]>
jeff-yin
requested changes
Oct 31, 2019
* Add default polling-interval. * Update sFlow data model. Signed-off-by: Garrick He <[email protected]>
* Fix revision table format. Signed-off-by: Garrick He <[email protected]>
* Fix revision table format. Signed-off-by: Garrick He <[email protected]>
jeff-yin
approved these changes
Nov 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add draft of sFlow HLD for SONiC Management Framework.
Signed-off-by: Garrick He [email protected]