Updated OC Interface HLD regarding rate utilization counters enhancements. #102
Conversation
rvasanthm
requested review from
jeff-yin,
joyas-joseph,
sameerdell and
bhavini-gada
doc/mgmt/SONiC_OC_Interface_HLD.md
Outdated
| `show interface counters` | ||
| Units: RX_MBPS/TX_MBPS(MB/s), RX_MbPS|TX_MbPS(Mb/s), RX_PPS|TX_PPS(pkts/s) | ||
|
|
||
| Interface State RX_OK RX_MBPS RX_MbPS RX_PPS RX_UTIL RX_ERR RX_DRP RX_OVR TX_OK TX_MBPS TX_MbPS TX_PPS TX_UTIL TX_ERR TX_DRP TX_OVR |
There was a problem hiding this comment.
RX_UTILS = will it show real time packets received in % ?
There was a problem hiding this comment.
Utilization counters are calculated based on the configured load interval window. Back end calculates and populates these counters (depends on load interval and polling interval) in counterdb and NBI just picks it up from there.
Please refer below HLD for more information:
https://github.com/BRCM-SONIC/sonic_doc_private/pull/43
doc/mgmt/SONiC_OC_Interface_HLD.md
Outdated
| IP MTU 9100 bytes | ||
| LineSpeed 25GB, Auto-negotiation off | ||
| Last clearing of "show interface" counters: 1970-01-01 00:00:00 | ||
| 30 seconds input rate 84640 bits/sec, 10236 Bytes/sec, 52 packets/sec |
There was a problem hiding this comment.
Can we have packets/sec first followed by bits/sec?
30 seconds input rate 52 packets/sec, 84640 bits/sec, 10236 Bytes/sec
Generally most of the vendors follow this order and hence the ask
…er the review comment.
|
Don't see any mention about queue counters and yang changes and CLI changes. |
|
Hello Rupesh,
CLI and Yang changes are not merged yet, PR’s opened and in WIP state, I am waiting to complete end to end validation with your backend changes. Please push your changes.
PR details:
1. https://gitlab.force10networks.com/e-sonic/sonic-mgmt-common/merge_requests/219
2. https://gitlab.force10networks.com/e-sonic/sonic-mgmt-framework/merge_requests/328
3. https://gitlab.force10networks.com/e-sonic/sonic-spytest/merge_requests/233
…-Ravi
From: rupesh-k <[email protected]>
Sent: Saturday, July 25, 2020 11:09 PM
To: project-arlo/SONiC
Cc: Vasanthm, Ravi; Author
Subject: Re: [project-arlo/SONiC] Updated OC Interface HLD regarding rate utilization counters enhancements. (#102)
[EXTERNAL EMAIL]
Don't see any mention about queue counters and yang changes and CLI changes.
Do I miss something ?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#102 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMMGZBOFYEQL3XELOARJHJDR5PCBJANCNFSM4OWX7POA>.
|
|
Thanks Ravi, I didn't see any mention about Queue Counters here in this document. So my question was regarding that. Sure. I will update u once I push my changes. Thanks
|
|
Hello Rupesh,
Queue counters changes was done by Ashok D (added him to the mail thread) and changes are already merged.
This HLD covers only interface rate and utilization counters enhancements.
…-Ravi
From: rupesh-k <[email protected]>
Sent: Sunday, July 26, 2020 11:24 AM
To: project-arlo/SONiC
Cc: Vasanthm, Ravi; Author
Subject: Re: [project-arlo/SONiC] Updated OC Interface HLD regarding rate utilization counters enhancements. (#102)
[EXTERNAL EMAIL]
Thanks Ravi, I didn't see any mention about Queue Counters here in this document. So my question was regarding that.
I hope u are covering that in your implementation.
Sure. I will update u once I push my changes.
I dont have access to these gitlab links.
May be I can pick from your branch in github, so I can do integration testing in my side once I push my changes.
Can I reach u on Slack for quick collaboration in next week.
Thanks
Rupesh Kumar
Hello Rupesh, CLI and Yang changes are not merged yet, PR’s opened and in WIP state, I am waiting to complete end to end validation with your backend changes. Please push your changes. PR details: 1. https://gitlab.force10networks.com/e-sonic/sonic-mgmt-common/merge_requests/219 2. https://gitlab.force10networks.com/e-sonic/sonic-mgmt-framework/merge_requests/328 3. https://gitlab.force10networks.com/e-sonic/sonic-spytest/merge_requests/233
…
-Ravi From: rupesh-k [email protected]<mailto:[email protected]> Sent: Saturday, July 25, 2020 11:09 PM To: project-arlo/SONiC Cc: Vasanthm, Ravi; Author Subject: Re: [project-arlo/SONiC] Updated OC Interface HLD regarding rate utilization counters enhancements. (#102<#102>) [EXTERNAL EMAIL] Don't see any mention about queue counters and yang changes and CLI changes. Do I miss something ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#102 (comment)<#102 (comment)>>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMMGZBOFYEQL3XELOARJHJDR5PCBJANCNFSM4OWX7POA.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#102 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMMGZBI7RSCSQMUOJGYLC3LR5RYDPANCNFSM4OWX7POA>.
|
|
Hi,
While supporting Klish “show queue counters” based on attached mail, I added queue rate counters in Klish “show queue counters” CLI.
If back end added below 2 counters in DB then we will see result in Klish CLI>
"SAI_QUEUE_STAT_PACKETS_PER_SECOND": "0",
"SAI_QUEUE_STAT_BYTES": "0",
"SAI_QUEUE_STAT_BYTES_PER_SECOND": "0",
Output in Klish:
sonic# show queue counters
----------------------------------------------------------------------------------------------------------------------------------------------
Port TxQ Counter/pkts Counter/bytes Rate/PPS Rate/BPS Drop/pkts Drop/bytes
----------------------------------------------------------------------------------------------------------------------------------------------
CPU MC0 0 0 0/s 0/s 0 0
CPU MC1 0 0 0/s 0/s 0 0
CPU MC2 0 0 0/s 0/s 0 0
Regards
Ashok D
From: Vasanthm, Ravi <[email protected]>
Sent: Monday, July 27, 2020 10:31 AM
To: project-arlo/SONiC; project-arlo/SONiC
Cc: Author; Daparthi, Ashok
Subject: RE: [project-arlo/SONiC] Updated OC Interface HLD regarding rate utilization counters enhancements. (#102)
Hello Rupesh,
Queue counters changes was done by Ashok D (added him to the mail thread) and changes are already merged.
This HLD covers only interface rate and utilization counters enhancements.
…-Ravi
From: rupesh-k <[email protected]<mailto:[email protected]>>
Sent: Sunday, July 26, 2020 11:24 AM
To: project-arlo/SONiC
Cc: Vasanthm, Ravi; Author
Subject: Re: [project-arlo/SONiC] Updated OC Interface HLD regarding rate utilization counters enhancements. (#102)
[EXTERNAL EMAIL]
Thanks Ravi, I didn't see any mention about Queue Counters here in this document. So my question was regarding that.
I hope u are covering that in your implementation.
Sure. I will update u once I push my changes.
I dont have access to these gitlab links.
May be I can pick from your branch in github, so I can do integration testing in my side once I push my changes.
Can I reach u on Slack for quick collaboration in next week.
Thanks
Rupesh Kumar
Hello Rupesh, CLI and Yang changes are not merged yet, PR’s opened and in WIP state, I am waiting to complete end to end validation with your backend changes. Please push your changes. PR details: 1. https://gitlab.force10networks.com/e-sonic/sonic-mgmt-common/merge_requests/219 2. https://gitlab.force10networks.com/e-sonic/sonic-mgmt-framework/merge_requests/328 3. https://gitlab.force10networks.com/e-sonic/sonic-spytest/merge_requests/233
…
-Ravi From: rupesh-k [email protected]<mailto:[email protected]> Sent: Saturday, July 25, 2020 11:09 PM To: project-arlo/SONiC Cc: Vasanthm, Ravi; Author Subject: Re: [project-arlo/SONiC] Updated OC Interface HLD regarding rate utilization counters enhancements. (#102<#102>) [EXTERNAL EMAIL] Don't see any mention about queue counters and yang changes and CLI changes. Do I miss something ? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#102 (comment)<#102 (comment)>>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AMMGZBOFYEQL3XELOARJHJDR5PCBJANCNFSM4OWX7POA.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#102 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AMMGZBI7RSCSQMUOJGYLC3LR5RYDPANCNFSM4OWX7POA>.
|
Changes:
show interface counters rate