Execute only first found binding and add message_dispatch tests

closes #6

lib/rubotnik/message_dispatch.rb

@@ -38,6 +38,8 @@ def bind_commands(&block)
     end
 
     def bind(*regex_strings, all: false, to: nil, reply_with: {})
+      return if @matched
+
       regexps = regex_strings.map { |rs| /\b#{rs}/i }
       proceed = regexps.any? { |regex| @message.text =~ regex }
       proceed = regexps.all? { |regex| @message.text =~ regex } if all

lib/rubotnik/user_store.rb

@@ -4,7 +4,7 @@
 class UserStore
   include Singleton
   attr_reader :users
-  
+
   def initialize
     @users = []
   end

rubotnik.gemspec

@@ -30,4 +30,6 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.15"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "factory_bot", "~> 4.0"
+  spec.add_development_dependency "pry"
 end

spec/factories/message.rb

@@ -0,0 +1,14 @@
+FactoryBot.define do
+  factory :message, class: Facebook::Messenger::Incoming::Message do
+    skip_create
+    initialize_with { new(attributes.stringify_keys) }
+
+    transient do
+      sender_id 1
+      text "bla"
+    end
+
+    sender { { "id" => sender_id } }
+    message { { "text" => text } }
+  end
+end

spec/factories/user.rb

@@ -0,0 +1,18 @@
+FactoryBot.define do
+  factory :user, class: User do
+    skip_create
+    initialize_with { new(attributes[:id].to_s) }
+
+    sequence(:id) { |n| n }
+
+    trait :with_commands do
+      transient do
+        commands { [] }
+      end
+
+      after(:build) do |user, evaluator|
+        evaluator.commands.each { |c| user.assign_command(c) }
+      end
+    end
+  end
+end

spec/lib/rubotnik/message_dispatch_spec.rb

@@ -0,0 +1,169 @@
+require "spec_helper"
+
+RSpec.describe Rubotnik::MessageDispatch do
+  let(:sender_id) { 2 }
+  let(:message) do
+    FactoryBot.build(:message, sender_id: sender_id, text: message_text)
+  end
+  let(:message_text) { "bla" }
+  let(:user) do
+    FactoryBot.build(:user, :with_commands, id: sender_id, commands: commands)
+  end
+  let(:commands) { [] }
+  let(:dispatch) { described_class.new(message) }
+  let(:commands_module) do
+    Module.new do
+      def command1
+      end
+
+      def command2
+      end
+    end
+  end
+
+  before do
+    allow(UserStore.instance).to receive(:find_or_create_user).
+      with(sender_id) { user }
+    dispatch.extend(commands_module)
+  end
+
+  describe "route" do
+    context "when user has an active command" do
+      let(:commands) { [:command1, :command2] }
+
+      it "executes the command" do
+        expect(dispatch).to receive(:command2)
+
+        dispatch.route
+      end
+
+      context "when a command raises an error" do
+        let(:debug) { nil }
+        let(:commands_module) do
+          Module.new do
+            def command2
+              raise "err"
+            end
+          end
+        end
+
+        before do
+          allow(ENV).to receive(:[]).and_wrap_original do |m, *args|
+            if args[0] == "DEBUG"
+              debug
+            else
+              m.call(*args)
+            end
+          end
+        end
+
+        context "and debug is on" do
+          let(:debug) { "true" }
+
+          it "shows the error" do
+            expect(dispatch).to receive(:say) { "There was an error: err" }
+
+            dispatch.route
+          end
+        end
+
+        context "and debug is off" do
+          it "reraises the error" do
+            expect(dispatch).to receive(:command2).and_call_original
+
+            expect { dispatch.route }.to raise_error("err")
+          end
+        end
+      end
+    end
+
+    context "with user has no active command" do
+      context "and message matches a binding with 'all: true'" do
+        let(:message_text) { "good morning" }
+
+        context "when :to option is given" do
+          it "executes the command" do
+            expect(dispatch).to receive(:command2)
+
+            dispatch.route do
+              bind "Good", "morning", all: true, to: :command2
+            end
+          end
+        end
+
+        context "when block is given" do
+          it "executes the command" do
+            expect(dispatch).to receive(:command1)
+
+            dispatch.route do
+              bind "Good", "morning", all: true do
+                command1
+              end
+            end
+          end
+        end
+      end
+
+      context "and message matches a binding without 'all: true'" do
+        let(:message_text) { "Morning, sir" }
+
+        context "when :to option is given" do
+          it "executes the command" do
+            expect(dispatch).to receive(:command2)
+
+            dispatch.route do
+              bind "Good", "morning", to: :command2
+            end
+          end
+        end
+
+        context "when block is given" do
+          it "executes the command" do
+            expect(dispatch).to receive(:command1)
+
+            dispatch.route do
+              bind "Good", "morning" do
+                command1
+              end
+            end
+          end
+        end
+      end
+
+      context "and message matches multiple commands" do
+        let(:message_text) { "do something" }
+
+        it "executes only the first matched command" do
+          expect(dispatch).to receive(:command1)
+          expect(dispatch).not_to receive(:command2)
+
+          dispatch.route do
+            bind "do", "something", all: true do
+              command1
+            end
+
+            bind "something" do
+              command2
+            end
+          end
+        end
+      end
+
+      context "and message matches no binding" do
+        it "executes 'default' block" do
+          expect(dispatch).to receive(:command1)
+
+          dispatch.route do
+            bind "something" do
+              command2
+            end
+
+            default do
+              command1
+            end
+          end
+        end
+      end
+    end
+  end
+end

spec/rubotnik_spec.rb

@@ -4,8 +4,4 @@
   it "has a version number" do
     expect(Rubotnik::VERSION).not_to be nil
   end
-
-  it "does something useful" do
-    expect(false).to eq(true)
-  end
 end

spec/spec_helper.rb

@@ -1,5 +1,7 @@
 require "bundler/setup"
 require "rubotnik"
+require "factory_bot"
+require "pry"
 
 RSpec.configure do |config|
   # Enable flags like --only-failures and --next-failure
@@ -8,4 +10,10 @@
   config.expect_with :rspec do |c|
     c.syntax = :expect
   end
+
+  config.include FactoryBot::Syntax::Methods
+
+  config.before(:suite) do
+    FactoryBot.find_definitions
+  end
 end