Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get MiMa running again #961

Merged
merged 3 commits into from
Jan 30, 2025
Merged

Get MiMa running again #961

merged 3 commits into from
Jan 30, 2025

Conversation

rossabaker
Copy link
Contributor

@rossabaker rossabaker commented Jan 28, 2025

There is a step in the workflow to run MiMa, but it doesn't have any previous versions, so nothing is being checked. The addition of new abstract methods to various algebras, along with some changes in types, means not all 1.x releases are compatible. This PR establishes a new baseline of compatible versions:

  • redis4cats-core: 1.7.1
  • redis4cats-log4cats: 1.4.3
  • redis4cats-effects: 1.7.2
  • redis4cats-streams: 1.7.2

@yisraelU
Copy link
Collaborator

@rossabaker 🙏 TY, much appreciated. this has been on my todo list for too long

@rossabaker
Copy link
Contributor Author

Since bincompat has already been broken, I don't know whether it's better to reset the MiMa versions to whatever passes and have the safety net from this point forward, or to release a 2.0.0 and let tooling flag that some 1.x versions contain breaking changes. The breakage is not a problem for applications using redis4cats directly, but is an issue for libraries that wrap it (e.g., epimetheus-redis4cats).

@rossabaker rossabaker marked this pull request as ready for review January 28, 2025 20:36
@rossabaker
Copy link
Contributor Author

Okay, if we want to proceed checking against compatible versions of each module, I think d61740d will do it. If we want to just start over as 2.0.0, we can drop d61740d, but still want 43e23a2 so the check runs on the new version.

@yisraelU yisraelU merged commit 9b6a0df into profunktor:series/1.x Jan 30, 2025
2 checks passed
@rossabaker rossabaker deleted the fix-mima branch January 30, 2025 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants