This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Fix the fixer :) for unsorted imports using as syntax
#43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [Named imports are not sorted in alphabetical order] | ||
|
|
||
| import { createMagic } from 'constants/magic'; | ||
| ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ [Import convention has been violated. This is auto-fixable.] |
There was a problem hiding this comment.
What's wrong with this one?
There was a problem hiding this comment.
This is actually nasty hack we are using. This line is there every time the issue is autofixable – that's because the fixer is connected to this line and the fixer works that it rewrite all the imports at once, not issue per issue. * shy boi *
There was a problem hiding this comment.
Ah I see! Okay makes sense, thanks 🎂
mauricekleine
approved these changes
May 13, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
check-unused-flux-dependencies
Issue was correctly discovered, but fixer failed to sort it. Added test.