This repository has been archived by the owner on Oct 6, 2020. It is now read-only.
Watch for selectors defined in the actual file #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The flux dependencies should be considered the same as imports. So you should be notified when you are using selector in other selector or connect without listening on it. close #20
jukben
force-pushed
the
feature/include-selectors-in-file
branch
from
496ac0c to
0457fcf
Compare
mauricekleine
approved these changes
Feb 27, 2019
|
Looking good man. Bumping to 2.0.1 sounds like a good idea! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The flux dependencies should be considered the same as imports. So you should be notified when you are using selector in other selector or connect without listening on it.
I personally consider this as a fix. So I would bump the rule to 2.0.1. Ideas?
close #20