Skip to content
This repository has been archived by the owner on Oct 6, 2020. It is now read-only.

rename check-unused-selectors to check-unused-flux-dependencies #16

Merged
merged 1 commit into from
Feb 6, 2019
Merged

rename check-unused-selectors to check-unused-flux-dependencies #16

merged 1 commit into from
Feb 6, 2019

Conversation

mauricekleine
Copy link
Contributor

@mauricekleine mauricekleine commented Feb 6, 2019 •
edited
Loading

This resolve issue #16

@mauricekleine mauricekleine requested a review from jukben February 6, 2019 14:04
@mauricekleine mauricekleine self-assigned this Feb 6, 2019
@jukben
Copy link
Contributor

jukben commented Feb 6, 2019 •
edited
Loading

Thanks! 🙏 Just a detail, you have probably wrongly renamed the folders

test/rules/check-unused-flux-selectors

should be test/rules/check-unused-flux-dependencies, right?

@mauricekleine mauricekleine force-pushed the chore/rename-check-unused-selectors branch from 80fbf52 to ce33416 Compare February 6, 2019 14:36
jukben
jukben approved these changes Feb 6, 2019
View reviewed changes
Copy link
Contributor

@jukben jukben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hell yeah! ✊

@mauricekleine mauricekleine merged commit dbd20b9 into master Feb 6, 2019
@mauricekleine mauricekleine deleted the chore/rename-check-unused-selectors branch February 6, 2019 14:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jukben jukben jukben approved these changes

Assignees

@mauricekleine mauricekleine

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mauricekleine @jukben