Dont treat PropertyAssignments -> Indentifier as Flux Identifier

productboardlabs · May 9, 2019 · e74dac5 · e74dac5
1 parent 47ba8b6
commit e74dac5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/src/rules/checkUnusedFluxDependenciesRule.ts b/src/rules/checkUnusedFluxDependenciesRule.ts
@@ -160,6 +160,7 @@ class NoUnusedDependenciesWalker extends Lint.RuleWalker {
         if (
           ts.isIdentifier(startNode) &&
           !ts.isTypeReferenceNode(startNode.parent) &&
+          !ts.isPropertyAssignment(startNode.parent) &&
           !ts.isPropertyAccessExpression(startNode.parent)
         ) {
           const identifier = startNode.text;

diff --git a/test/rules/check-unused-flux-dependencies/test.8.tsx.lint b/test/rules/check-unused-flux-dependencies/test.8.tsx.lint
@@ -12,3 +12,10 @@ export default select([anotherSelect], () => {
     magic: anotherSelect(),
   }
 })
+
+export default select([anotherSelect], () => {
+  return {
+    show: "must go on",
+    magic: anotherSelect(),
+  }
+})