Skip to content
This repository has been archived by the owner on Jan 19, 2021. It is now read-only.

Defensives and better replace Defs #13

Merged
merged 2 commits into from
Apr 13, 2019
Merged

Defensives and better replace Defs #13

merged 2 commits into from
Apr 13, 2019

Conversation

jukben
Copy link
Contributor

@jukben jukben commented Apr 12, 2019 •
edited
Loading

Fixes crash for some icons (exported from Figma) plus better replace without parentheses.

close #12
close #3

@jukben jukben requested a review from mauricekleine April 12, 2019 11:38
@jukben jukben force-pushed the fix/better-replace branch from 7216e13 to c5bd642 Compare April 12, 2019 11:38
@jukben jukben changed the title Fix/better replace Defensives and better replace Defs Apr 12, 2019
mauricekleine
mauricekleine approved these changes Apr 12, 2019
View reviewed changes
Copy link

@mauricekleine mauricekleine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! Awesomesauce ⭐️

@jukben jukben merged commit b3a720e into master Apr 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mauricekleine mauricekleine mauricekleine approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing check for name (Use) Remove unnecessary attributes
2 participants
@jukben @mauricekleine