-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BREAKING: Remove opt-in repo configuration #833
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
62 repositories appear to be affected, some of them external to balena orgs. We should PR these to remove the inputs before merging the breaking change. |
klutchell
force-pushed
the
kyle/remove-repo-config
branch
from
December 19, 2023 17:32
3e0e754
to
ab37c09
Compare
klutchell
changed the title
Remove opt-in repo configuration
BREAKING: Remove opt-in repo configuration
Dec 19, 2023
klutchell
force-pushed
the
kyle/remove-repo-config
branch
from
December 19, 2023 19:00
ab37c09
to
73a317b
Compare
klutchell
added a commit
to balena-io/etcher
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io/etcher
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to people-os/support-shift-scheduler
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-experimental/balena-k3s
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io/etcher
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to people-os/support-shift-scheduler
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-experimental/balena-k3s
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-modules/resin-cli-visuals
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-os/balena-sign
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io/autohat-ondevice
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-os/cloud-config
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
This was referenced Dec 19, 2023
klutchell
added a commit
to balena-io-modules/balena-image-fs
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-library/base-images
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-modules/drivelist
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-modules/winusb-driver-generator
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io/sshproxy
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-modules/node-qmp
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io/etcher
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to people-os/support-shift-scheduler
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-modules/drivelist
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-experimental/gazette
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to product-os/policy-bot
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-experimental/balena-firecracker
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to product-os/policies
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io-modules/etcher-sdk
that referenced
this pull request
Dec 19, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
This was referenced Dec 19, 2023
klutchell
added a commit
to product-os/policy-bot
that referenced
this pull request
Dec 20, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
klutchell
added a commit
to balena-io/etcher
that referenced
this pull request
Dec 20, 2023
This functionality is being deprecated in Flowzone. See: product-os/flowzone#833 Change-type: patch Signed-off-by: Kyle Harding <[email protected]>
Allowing Flowzone to make repo configuration changes via administrator tokens effectively grants any user with write permissions the ability to make admin changes. Repo configuration should be handled outside of the CI context where administrator permissions can be granted to a central authority only. This is a breaking change for repos that previously opted into these settings. This workflow will not run unless the calling workflow omits the related inputs. Change-type: major Signed-off-by: Kyle Harding <[email protected]>
klutchell
force-pushed
the
kyle/remove-repo-config
branch
from
January 2, 2024 14:19
73a317b
to
f90ec21
Compare
ab77
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing Flowzone to make repo configuration changes
via administrator tokens effectively grants any user with
write permissions the ability to make admin changes.
Repo configuration should be handled outside of the CI
context where administrator permissions can be granted to
a central authority only.
This is a breaking change for repos that previously opted into these settings.
This workflow will not run unless the calling workflow omits the related inputs.
Change-type: major
See: https://balena.fibery.io/Work/Improvement/Move-repo-config-out-of-Flowzone-CI-1388
See: https://balena.fibery.io/Work/Project/Host-the-safe-settings-GitHub-App-for-repository-management-190
Resolves: #729