Stop the whole worker process when a coroutine raises #494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ewjoachim
commented
Nov 28, 2021
| exc: Exception | ||
|
|
||
|
|
||
| async def run_tasks( |
There was a problem hiding this comment.
All in all, this function is 150 lines long, but there's a lot of doc/comments. Also, I'm not sure how to split it more efficiently. The base logic would be shorter but it order to log in all the strategic places, and because asyncio.Task supports task names only on 3.8+, we end up with more complex code.
ewjoachim
force-pushed
the
exception-swallowed-493
branch
from
9edc169 to
3f7ca87
Compare
|
@ewjoachim thank you for the speedy fix! I tested this branch in my environment and it solves the issue. |
|
Thanks for your feedback :) I'll try to have this merged and released in the near future. |
ewjoachim
force-pushed
the
exception-swallowed-493
branch
from
555d146 to
c2588e3
Compare
Coverage reportThe coverage rate went from The branch rate is
Diff Coverage details (click to unfold)procrastinate/utils.py
procrastinate/worker.py
procrastinate/exceptions.py
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #493
@kriscode1 you may want to checkout this PR and test that it solves your problem.
Successful PR Checklist: