Fix docstring and Psycopg2Connector __init__ signature #447
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 16, 2021 08:06
The Psycopg2Connector __init__ function does not have a pool argument. A user-created pool can be used, but it's to be passed to the open function.
elemoine
requested review from
DainDwarf,
ewjoachim,
pmourlanne,
sophie-ulti and
thomasperrot
as code owners
Codecov Report
@@ Coverage Diff @@
## master #447 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 1635 1635
Branches 178 178
=========================================
Hits 1635 1635
Continue to review full report at Codecov.
|
ewjoachim
approved these changes
Sep 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes two minor changes to
psycopg2_connector.py:wrap_exceptionsdecorator function,poolargument to thePsycopg2Connector.__init__function.Successful PR Checklist: