-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Null locks are ignored #402
Conversation
@elemoine I'd love your input on this one someday :) |
@@ -0,0 +1,36 @@ | |||
DROP FUNCTION IF EXISTS procrastinate_fetch_job(target_queue_names character varying[]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will work with our deprecation policy but another brain validating that would be great :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it will work. The new SQL function has the same arguments signature as the old SQL function, so it is compatible with the Python code of previous Procrastinate versions.
Codecov Report
@@ Coverage Diff @@
## master #402 +/- ##
==========================================
- Coverage 99.87% 99.87% -0.01%
==========================================
Files 28 28
Lines 1612 1611 -1
Branches 175 175
==========================================
- Hits 1610 1609 -1
Misses 1 1
Partials 1 1
Continue to review full report at Codecov.
|
This looks good to me! Thank you again @ewjoachim. |
No idea how to test this cleanly though. |
195d8a7
to
895663d
Compare
Brain switched on. Tests added. |
Coverage reportThe coverage rate went from The branch rate is
|
Closes #400
Successful PR Checklist: