Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Null locks are ignored #402

Merged
merged 1 commit into from
Oct 3, 2021
Merged

Null locks are ignored #402

merged 1 commit into from
Oct 3, 2021

Conversation

ewjoachim
Copy link
Member

@ewjoachim ewjoachim commented May 21, 2021

Closes #400

Successful PR Checklist:

  • Tests < I'd like if we could add some tests, but not sure which
    • (not applicable?)
  • Documentation
    • (not applicable?)
  • If Add list_locks #401 if merged before, we may need to change a thing or two

@ewjoachim
Copy link
Member Author

@elemoine I'd love your input on this one someday :)

@@ -0,0 +1,36 @@
DROP FUNCTION IF EXISTS procrastinate_fetch_job(target_queue_names character varying[]);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will work with our deprecation policy but another brain validating that would be great :D

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it will work. The new SQL function has the same arguments signature as the old SQL function, so it is compatible with the Python code of previous Procrastinate versions.

@codecov
Copy link

codecov bot commented May 21, 2021

Codecov Report

Merging #402 (195d8a7) into master (e9fc5e6) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #402      +/-   ##
==========================================
- Coverage   99.87%   99.87%   -0.01%     
==========================================
  Files          28       28              
  Lines        1612     1611       -1     
  Branches      175      175              
==========================================
- Hits         1610     1609       -1     
  Misses          1        1              
  Partials        1        1              
Impacted Files Coverage Δ
procrastinate/manager.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e9fc5e6...195d8a7. Read the comment docs.

@ewjoachim
Copy link
Member Author

🤙 @elemoine

@elemoine
Copy link
Contributor

elemoine commented Aug 3, 2021

This looks good to me! Thank you again @ewjoachim.

@elemoine elemoine mentioned this pull request Aug 3, 2021
4 tasks
@ewjoachim
Copy link
Member Author

No idea how to test this cleanly though.

@ewjoachim
Copy link
Member Author

Brain switched on. Tests added.

@ewjoachim ewjoachim marked this pull request as ready for review October 3, 2021 14:31
@ewjoachim ewjoachim requested a review from pmourlanne as a code owner October 3, 2021 14:31
@ewjoachim ewjoachim enabled auto-merge October 3, 2021 14:31
@ewjoachim ewjoachim merged commit cfb5fbc into master Oct 3, 2021
@ewjoachim ewjoachim deleted the periodic-lock-400 branch October 3, 2021 14:32
@github-actions
Copy link

github-actions bot commented Oct 3, 2021

Coverage report

The coverage rate went from 100.0% to 100.0% ➡️

The branch rate is 99.72999999999999%

100% of new lines are covered.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Periodic tasks have a NULL lock
2 participants