Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small fix for dev-env script #387

Merged
merged 1 commit into from
Feb 12, 2021
Merged

Small fix for dev-env script #387

merged 1 commit into from
Feb 12, 2021

Conversation

mxd4
Copy link
Contributor

@mxd4 mxd4 commented Feb 12, 2021

The PROCRASTINATE_APP definition needs to happen before applying the schema, otherwise we get a Missing app error. I guess this was not detected before because the script only ran on environments where the variable was already defined or the schema already applied.

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)
  • Had a good time contributing?

@codecov
Copy link

codecov bot commented Feb 12, 2021

Codecov Report

Merging #387 (dbbefee) into master (136d7ff) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #387   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1607      1607           
  Branches       173       173           
=========================================
  Hits          1607      1607           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136d7ff...f3506b1. Read the comment docs.

@ewjoachim ewjoachim merged commit e2f0061 into master Feb 12, 2021
@ewjoachim ewjoachim deleted the dev-env-export-fix branch February 12, 2021 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR type: bugfix 🕵️ Contains bug fix PR type: miscellaneous 👾 Contains misc changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants