Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add todo check for queueing lock, add test for todo check #379

Merged
merged 4 commits into from
Jan 13, 2021
Merged

add todo check for queueing lock, add test for todo check #379

merged 4 commits into from
Jan 13, 2021

Conversation

BracketJohn
Copy link
Contributor

Closes #378

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)
  • Had a good time contributing?

@BracketJohn BracketJohn mentioned this pull request Jan 12, 2021
Closed
@codecov
Copy link

codecov bot commented Jan 12, 2021 •
edited
Loading

Codecov Report

Merging #379 (183e922) into master (80576fc) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #379   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1604      1604           
  Branches       173       173           
=========================================
  Hits          1604      1604
Impacted Files Coverage Δ
procrastinate/testing.py 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 80576fc...c4a67c8. Read the comment docs.

ewjoachim
ewjoachim approved these changes Jan 13, 2021
View reviewed changes
Copy link
Member

@ewjoachim ewjoachim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very nice. Thanks for the contribution. @elemoine I'll let you merge if it's ok for you, and I believe we can issue a hotfix release :)

@elemoine elemoine merged commit f280dfe into procrastinate-org:master Jan 13, 2021
@ewjoachim
Copy link
Member

https://pypi.org/project/procrastinate/0.18.1/

@BracketJohn BracketJohn deleted the add_inmemory_queueing_lock_todo_check branch January 13, 2021 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewjoachim ewjoachim ewjoachim approved these changes

@DainDwarf DainDwarf Awaiting requested review from DainDwarf

@elemoine elemoine Awaiting requested review from elemoine

@mgu mgu Awaiting requested review from mgu

@pmourlanne pmourlanne Awaiting requested review from pmourlanne

@sophie-ulti sophie-ulti Awaiting requested review from sophie-ulti

@thomasperrot thomasperrot Awaiting requested review from thomasperrot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

InMemoryConnector and AiopgConnector _still_ handle queueing_lock differently
3 participants
@BracketJohn @ewjoachim @elemoine