Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deployment pipeline #360

Merged
merged 1 commit into from
Dec 1, 2020
Merged

Fix deployment pipeline #360

merged 1 commit into from
Dec 1, 2020

Conversation

ewjoachim
Copy link
Member

The deployment pipeline was accidentally broken in #322, here's the fix.

Successful PR Checklist:

  • Tests < manually tested
    • (not applicable?)
  • Documentation
    • (not applicable?)
  • Had a good time contributing?

@codecov
Copy link

codecov bot commented Dec 1, 2020 •
edited
Loading

Codecov Report

Merging #360 (1153755) into master (ef79690) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #360   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         1579      1580    +1     
  Branches       173       173           
=========================================
+ Hits          1579      1580    +1
Impacted Files Coverage Δ
procrastinate/cli.py 100.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dffb608...1153755. Read the comment docs.

@ewjoachim ewjoachim mentioned this pull request Dec 1, 2020
Merged
5 tasks
thomasperrot
thomasperrot approved these changes Dec 1, 2020
View reviewed changes
.github/workflows/deploy.yml Outdated Show resolved Hide resolved
elemoine
elemoine approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@elemoine elemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of that @ewjoachim!

@ewjoachim ewjoachim merged commit adb0e75 into master Dec 1, 2020
@ewjoachim ewjoachim deleted the deployment branch December 1, 2020 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elemoine elemoine elemoine approved these changes

@thomasperrot thomasperrot thomasperrot approved these changes

@DainDwarf DainDwarf Awaiting requested review from DainDwarf

@mgu mgu Awaiting requested review from mgu

@pmourlanne pmourlanne Awaiting requested review from pmourlanne

@sophie-ulti sophie-ulti Awaiting requested review from sophie-ulti

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewjoachim @elemoine @thomasperrot