Remove the Sphinx bug-related addendum in the doc #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elemoine
requested review from
DainDwarf,
ewjoachim,
mgu,
pmourlanne and
sophie-ulti
as code owners
Codecov Report
@@ Coverage Diff @@
## master #351 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 1568 1568
Branches 171 171
=========================================
Hits 1568 1568
Continue to review full report at Codecov.
|
|
Based on #352, which is to be merged first. |
ewjoachim
reviewed
Nov 20, 2020
tests/acceptance/test_shell.py
Outdated
| @@ -5,14 +5,15 @@ | |||
|
|
|||
| @pytest.fixture | |||
| def shell(process_env): | |||
| return subprocess.Popen( | |||
| with subprocess.Popen( | |||
There was a problem hiding this comment.
TIL with subprocess.Popen 😮 👍
ewjoachim
approved these changes
Nov 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #200
Successful PR Checklist: