Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Job Store > Job Manager #335

Merged
merged 4 commits into from
Oct 10, 2020
Merged

Rename Job Store > Job Manager #335

merged 4 commits into from
Oct 10, 2020

Conversation

ewjoachim
Copy link
Member

Refs #333 (that mentions the renaming)

Successful PR Checklist:

  • Tests
    • (not applicable?)
  • Documentation
    • (not applicable?)
  • Had a good time contributing?

@codecov
Copy link

codecov bot commented Oct 9, 2020

Codecov Report

Merging #335 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #335   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           30        30           
  Lines         1609      1609           
  Branches       183       183           
=========================================
  Hits          1609      1609           
Impacted Files Coverage Δ
procrastinate/testing.py 100.00% <ø> (ø)
procrastinate/app.py 100.00% <100.00%> (ø)
procrastinate/builtin_tasks.py 100.00% <100.00%> (ø)
procrastinate/jobs.py 100.00% <100.00%> (ø)
procrastinate/manager.py 100.00% <100.00%> (ø)
procrastinate/periodic.py 100.00% <100.00%> (ø)
procrastinate/tasks.py 100.00% <100.00%> (ø)
procrastinate/worker.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f831565...78df776. Read the comment docs.

@ewjoachim
Copy link
Member Author

ewjoachim commented Oct 9, 2020

So many things have been renamed in the project. App was once TaskManager (and that was before Task was renamed Job) so the circle is now complete :D

https://github.com/peopledoc/procrastinate/search?q=Rename+is%3Aissue+is%3Apr&type=Issues

What is this project about ? We rename things and move code around instead of doing productive things. What's it called ? Procrastinate.

@ewjoachim ewjoachim changed the title Rename Job Store > Job manager Rename Job Store > Job Manager Oct 9, 2020
Copy link
Contributor

@elemoine elemoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great procrastination! Please merge.

@ewjoachim ewjoachim merged commit ddd2d19 into master Oct 10, 2020
@ewjoachim ewjoachim deleted the job-manager branch October 10, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants