Make test_run_log_current_job_when_stopping more robust #317
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make test_run_log_current_job_when_stopping more robust by not attempting to guess about the time that lasted since the task started.
elemoine
added
PR type: miscellaneous 👾
elemoine
requested review from
DainDwarf,
ewjoachim,
mgu,
pmourlanne and
sophie-ulti
as code owners
Codecov Report
@@ Coverage Diff @@
## master #317 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 30 30
Lines 1609 1609
Branches 183 183
=========================================
Hits 1609 1609 Continue to review full report at Codecov.
|
ewjoachim
approved these changes
Sep 17, 2020
|
Let's close the pi ticket :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
test_run_log_current_job_when_stoppingmore robust by not attempting to guess about the time that lasted since the task started.Closes #314
Successful PR Checklist: